Review main Merged

85813[TASK] Deprecate ext:fluid fillDefaultsByPackageName()

Christian Kuhn CR +2 V +2 Normal +89 −108 updated 08/28/24, 14:39

Commit message

TemplatePaths->fillDefaultsByPackageName() is located
at the wrong place by having this magic within ext:fluid:
It is the last piece of ext:fluid core (non-VH) classes
that mixes extbase logic into fluid.

The method is only triggered actively by extbase, and
indirectly via parent __construct() in standalone fluid
if the class is constructed with a string, which is not
used by the core.

The patch refactors the single consumer in extbase
ActionController, which leads to simplified fluid path
setup in that class. Two obsolete heavy mocking tests
that don't add value bite the dust along the way.

Even though ext:fluid TemplatePaths is marked @internal,
the method is not removed directly but deprecated since
it is used by quite a few extensions in practice, and
it does not harm much to just let it log deprecation
note in v13.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Christian Kuhn uploaded patch set 1 08/28/24, 13:22

  2. core-ci voted on patch set 1 V +1 08/28/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64422

  3. Christian Kuhn uploaded patch set 2 V +1 08/28/24, 13:58

  4. core-ci voted on patch set 2 V +1 08/28/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64425

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 08/28/24, 14:23

  6. Simon Praetorius voted on patch set 2 CR +1 V +1 08/28/24, 14:28

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 08/28/24, 14:39

  8. Christian Kuhn merged patch set 3 08/28/24, 14:39