Review main Merged

85820[TASK] Declare minor ext:form RendererInterface change

Christian Kuhn CR +2 V +2 Easy +3 −6 updated 08/29/24, 08:40

Commit message

ext:form RendererInterface->setFormRuntime() now declares
to return void. Strictly speaking this would be a breaking
change, but it is not in practice, since extensions
typically do not implement the interface directly, but
extend AbstractElementRenderer, which follows this interface
change. Also, existing extensions could easily declare :void
(if they don't do so already), and be v13 and <v13 compatible
without problems.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 08/28/24, 21:49

  2. Stefan Bürk voted on patch set 1 CR +1 V +1 08/28/24, 21:55

  3. core-ci voted on patch set 1 V +1 08/28/24, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64439

  4. Benjamin Franzke commented on patch set 1 CR +2 V +2 08/29/24, 08:40

  5. Benjamin Franzke merged patch set 2 08/29/24, 08:40