Review main Merged

85822[TASK] Do not declare extbase defaultViewObjectName, set it

Christian Kuhn CR +2 V +2 Normal +27 −55 updated 08/28/24, 22:42

Commit message

Instead of declaring ActionController->defaultViewObjectName
to some value, __construct() sets it. This in line with the
recommended solution of #102632: It relaxes liskov covariance
and contravariance issues with PHP properties. Core usages now
follow to be a good example for extensions. The patch applies
minor constructor/DI cleanups along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/28/24, 22:30

  2. Benni Mack voted on patch set 1 CR +1 V +1 08/28/24, 22:32

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 08/28/24, 22:34

  4. core-ci voted on patch set 1 V +1 08/28/24, 22:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64441

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 08/28/24, 22:41

  6. Christian Kuhn merged patch set 2 08/28/24, 22:42