Review main Merged

85827[BUGFIX] Allow Extbase HashService retrieval via GeneralUtility::makeInstance()

Torben Hansen CR +2 V +2 Easy +2 −6 updated 08/30/24, 12:54

Commit message

With the deprecation of extbase `HashService`, the new core
`HashService` was injected to extbase `HashService` using constructor
DI. Instantiation of extbase `HashService` however does not work,
because the service is defined by a service provider and the
required constructor argument is missing.

This change makes the extbase `HashService` injectable by DI
again by removing it from the service provider definition and
by defining it as public using `Autoconfigure` attribute.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 1015

  1. Torben Hansen uploaded patch set 1 08/30/24, 07:27

  2. Mathias Brodala commented on patch set 1 CR -1 08/30/24, 07:30

    HashService.php:35

    Since HashService is stateless, there is no point in marking it as singleton. Please add "public: true" in Services.yaml instead.
  3. core-ci voted on patch set 1 V +1 08/30/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64513

  4. Torben Hansen uploaded patch set 2 CR -1 V +1 08/30/24, 07:44

  5. Torben Hansen commented on patch set 2 08/30/24, 07:45

    HashService.php:35 Reply

    Done, but used `#[Autoconfigure(public: true)]` attibute instead
  6. core-ci voted on patch set 2 V -1 08/30/24, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64514

  7. Torben Hansen updated the commit message in patch set 3 V -1 08/30/24, 08:06

  8. core-ci voted on patch set 3 V -1 08/30/24, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64516

  9. Benjamin Franzke voted on patch set 3 CR +1 V +1 08/30/24, 08:31

  10. core-ci voted on patch set 3 V +1 08/30/24, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64516

  11. Mathias Brodala updated the commit message in patch set 4 CR +1 V +1 08/30/24, 12:38

  12. Mathias Brodala voted on patch set 4 CR +1 08/30/24, 12:38

  13. core-ci voted on patch set 4 V +1 08/30/24, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64529

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 08/30/24, 12:54

  15. Christian Kuhn merged patch set 5 08/30/24, 12:54