85827[BUGFIX] Allow Extbase HashService retrieval via GeneralUtility::makeInstance()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Mathias Brodala +1
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 2
Files 2
Review log 1015
-
Torben Hansen uploaded patch set 1 08/30/24, 07:27
-
Mathias Brodala commented on patch set 1 CR -1 08/30/24, 07:30
-
core-ci voted on patch set 1 V +1 08/30/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64513
-
Torben Hansen uploaded patch set 2
CR -1V +108/30/24, 07:44 -
Torben Hansen commented on patch set 2 08/30/24, 07:45
HashService.php:35ReplyDone, but used `#[Autoconfigure(public: true)]` attibute instead -
core-ci voted on patch set 2 V -1 08/30/24, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64514
-
Torben Hansen updated the commit message in patch set 3
V -108/30/24, 08:06 -
core-ci voted on patch set 3 V -1 08/30/24, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64516
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 08/30/24, 08:31
-
core-ci voted on patch set 3 V +1 08/30/24, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64516
-
Mathias Brodala updated the commit message in patch set 4
CR +1V +108/30/24, 12:38 -
Mathias Brodala voted on patch set 4 CR +1 08/30/24, 12:38
-
core-ci voted on patch set 4 V +1 08/30/24, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64529
-
Christian Kuhn voted on patch set 4 CR +2 V +2 08/30/24, 12:54
-
Christian Kuhn merged patch set 5 08/30/24, 12:54
HashService.php:35