Review main Merged

85830[TASK] Prepare TemplatePaths for new Fluid version

Simon Praetorius CR +2 V +2 Easy +5 −21 updated 08/30/24, 16:49

Commit message

Some type hints in TYPO3's TemplatePaths implementation need to
be adjusted due to changes in the parent class. Also,
`ensureAbsolutePath()` now only handles `string` as input, as the
parent class is the only position the method is called and only strings
are valid in that context.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Simon Praetorius uploaded patch set 1 08/30/24, 12:43

  2. core-ci voted on patch set 1 V -1 08/30/24, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64530

  3. Simon Praetorius uploaded patch set 2 V -1 08/30/24, 12:57

  4. core-ci voted on patch set 2 V -1 08/30/24, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64531

  5. Simon Praetorius uploaded patch set 3 V -1 08/30/24, 13:17

  6. core-ci voted on patch set 3 V -1 08/30/24, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64532

  7. Simon Praetorius uploaded patch set 4 V -1 08/30/24, 13:34

  8. core-ci voted on patch set 4 V +1 08/30/24, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64533

  9. Simon Praetorius marked it ready for review 08/30/24, 13:52

  10. Stefan Bürk voted on patch set 4 CR +1 V +1 08/30/24, 13:58

  11. Garvin Hicking voted on patch set 4 CR +1 V +1 08/30/24, 16:49

  12. Simon Praetorius voted on patch set 4 CR +2 V +2 08/30/24, 16:49

  13. Simon Praetorius merged patch set 5 08/30/24, 16:49