85832[TASK] Avoid calls to TemplatePaths constructor
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Markus Klein +1
- Stefan Bürk +1
-
Verified V +2 Done
- Simon Praetorius +2
- Markus Klein +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Mail/FluidEmail.php+7 −1
- typo3/sysext/felogin/Classes/Configuration/RecoveryConfiguration.php3+14 −14
- typo3/sysext/felogin/Tests/Unit/Configuration/RecoveryConfigurationTest.php+5 −5
- typo3/sysext/fluid/Tests/Unit/View/TemplatePathsTest.php+9 −9
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php3+7 −3
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php2+8 −3
- typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php3+14 −1
Review log 2030
Show 35 earlier messages
-
Simon Praetorius uploaded patch set 1 08/30/24, 14:26
-
core-ci voted on patch set 1 V -1 08/30/24, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64536
-
Simon Praetorius rebased onto patch set 2
V -108/30/24, 17:11 -
core-ci voted on patch set 2 V -1 08/30/24, 17:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64542
-
Simon Praetorius uploaded patch set 3
V -108/30/24, 17:40
-
core-ci voted on patch set 3 V -1 08/30/24, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64544
-
Simon Praetorius updated the commit message in patch set 4
V -108/30/24, 21:25 -
core-ci voted on patch set 4 V -1 08/30/24, 21:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64560
-
Simon Praetorius uploaded patch set 5
V -109/03/24, 17:56 -
core-ci voted on patch set 5 V -1 09/03/24, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64692
-
core-ci commented on patch set 5 09/03/24, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64692
-
core-ci voted on patch set 5 V +1 09/03/24, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64692
-
Simon Praetorius uploaded patch set 6
V +109/04/24, 18:41 -
Simon Praetorius updated the commit message in patch set 7 09/04/24, 18:43
-
Simon Praetorius marked it ready for review 09/04/24, 18:45
-
core-ci voted on patch set 6 V +1 09/04/24, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64804
-
core-ci voted on patch set 7 V +1 09/04/24, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64805
-
Markus Klein commented on patch set 7 09/04/24, 20:37
StageChangeNotification.php:145same here -
Stefan Bürk commented on patch set 7 09/04/24, 20:47
AuthenticationService.php:46I'm not sure if we should use `array_replace()` here to emphasize what here really happens as understanding this construct may be not obvious on the first look: * array key and value unpacking flattern * replaceing key `20` with manual item below Albeit, I love that construct/syntax using more "known" construct may be usefull for not so experienced people ?SystemStatusUpdateTask.php:121I'm not sure if we should use `array_replace()` here to emphasize what here really happens as understanding this construct may be not obvious on the first look: * array key and value unpacking flattern * replaceing key `20` with manual item below Albeit, I love that construct/syntax using more "known" construct may be usefull for not so experienced people ? -
Stefan Bürk commented on patch set 7 09/04/24, 20:49
RecoveryConfiguration.php:69Replyrecursive does not make sense. The recursive was because it was applied on an array containing subarrays with `templateRootPaths`. The structure here is ``` int => string ``` and recursive does not make any sense.StageChangeNotification.php:145Replyrecursive does not make sense. The recursive was because it was applied on an array containing subarrays with `templateRootPaths`. The structure here is ``` int => string ``` and recursive does not make any sense. -
Simon Praetorius commented on patch set 7 09/05/24, 07:03
AuthenticationService.php:46ReplyI think I'll switch these to `array_replace()` in all places. That way the API is used in the same way everywhere. -
Markus Klein commented on patch set 7 09/05/24, 07:17
RecoveryConfiguration.php:69ReplyRight, I overlooked that.StageChangeNotification.php:145ReplyAcknowledged -
Simon Praetorius uploaded patch set 8
V +109/05/24, 08:22 -
Simon Praetorius commented on patch set 8 09/05/24, 08:23
AuthenticationService.php:46ReplyDoneSystemStatusUpdateTask.php:121ReplyDone -
core-ci voted on patch set 8 V +1 09/05/24, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64845
-
Markus Klein voted on patch set 8 CR +1 09/08/24, 07:45
-
Markus Klein voted on patch set 8 V +1 09/09/24, 08:02
-
Stefan Bürk voted on patch set 8 CR +1 V +1 09/09/24, 11:03
-
Simon Praetorius voted on patch set 8 CR +2 V +2 09/09/24, 11:24
-
Simon Praetorius merged patch set 9 09/09/24, 11:24
RecoveryConfiguration.php:69