85834[TASK] Avoid renderStatic() in ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 69
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php+2 −6
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php+3 −9
- typo3/sysext/backend/Classes/ViewHelpers/Toolbar/AttributesViewHelper.php+2 −11
- typo3/sysext/backend/Classes/ViewHelpers/TypoScript/FineDiffViewHelper.php+2 −4
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php+10 −17
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php+11 −21
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php+4 −10
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php+10 −16
- typo3/sysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.php+1 −14
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+2 −7
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php+2 −8
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php+2 −7
- typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php+4 −9
- typo3/sysext/beuser/Classes/ViewHelpers/IsArrayViewHelper.php+2 −6
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+6 −15
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php+2 −11
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php+5 −9
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php+5 −9
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php+8 −12
- typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php+3 −7
Show 49 more files
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ConstraintsViewHelper.php+2 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/InstallationStateCssClassViewHelper.php+3 −7
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php+2 −6
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+7 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php+2 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+2 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+10 −18
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+10 −19
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php+9 −16
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+6 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CurrencyViewHelper.php+9 −16
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+8 −17
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesDecodeViewHelper.php+5 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlentitiesViewHelper.php+6 −12
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+9 −19
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php+5 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+11 −19
- typo3/sysext/fluid/Classes/ViewHelpers/Sanitize/HtmlViewHelper.php+3 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Transform/HtmlViewHelper.php+4 −11
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php+5 −9
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ExternalViewHelper.php+3 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+23 −29
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+6 −10
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php+4 −7
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+6 −12
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+8 −12
- typo3/sysext/fluid/Classes/ViewHelpers/DebugViewHelper.php+9 −13
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+10 −21
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+9 −17
- typo3/sysext/fluid/Tests/Functional/Fixtures/Libraries/viewhelper_library/src/ViewHelpers/TestViewHelper.php+2 −9
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php+6 −12
- typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/Be/MaximumFileSizeViewHelper.php+1 −5
- typo3/sysext/form/Classes/ViewHelpers/Be/RenderContentElementPreviewViewHelper.php+4 −12
- typo3/sysext/form/Classes/ViewHelpers/GridColumnClassAutoConfigurationViewHelper.php+2 −12
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+7 −14
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+14 −24
- typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php+4 −13
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+6 −10
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+4 −10
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+8 −17
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/DateTimeViewHelper.php+2 −6
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php+2 −6
- typo3/sysext/indexed_search/Classes/ViewHelpers/Format/GroupListViewHelper.php+2 −7
- typo3/sysext/indexed_search/Classes/ViewHelpers/SearchResult/RatingViewHelper.php+4 −9
- typo3/sysext/install/Classes/ViewHelpers/Format/NoSpaceViewHelper.php+2 −6
- typo3/sysext/install/Classes/ViewHelpers/Format/PhpErrorCodeViewHelper.php+2 −8
- typo3/sysext/install/Classes/ViewHelpers/PhpInfoViewHelper.php+1 −5
- typo3/sysext/redirects/Classes/ViewHelpers/TargetPageIdViewHelper.php+3 −8
Review log 1422
-
Simon Praetorius uploaded patch set 1 08/30/24, 18:54
-
Simon Praetorius uploaded patch set 2 08/30/24, 18:56
-
core-ci voted on patch set 1 V -1 08/30/24, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64549
-
core-ci voted on patch set 2 V -1 08/30/24, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64550
-
Simon Praetorius uploaded patch set 3
V -108/30/24, 19:26 -
core-ci voted on patch set 3 V -1 08/30/24, 19:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64552
-
Simon Praetorius uploaded patch set 4
V -108/30/24, 19:42 -
core-ci voted on patch set 4 V -1 08/30/24, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64553
-
Simon Praetorius uploaded patch set 5
V -108/30/24, 20:44 -
core-ci voted on patch set 5 V -1 08/30/24, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64557
-
Simon Praetorius rebased onto patch set 6
V -109/03/24, 15:29 -
core-ci voted on patch set 6 V -1 09/03/24, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64678
-
core-ci commented on patch set 6 09/03/24, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64678
-
Simon Praetorius uploaded patch set 7
V -109/03/24, 16:10 -
core-ci voted on patch set 7 V +1 09/03/24, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64686
-
Simon Praetorius marked it ready for review 09/03/24, 17:46
-
Benni Mack voted on patch set 7 CR +1 09/04/24, 10:27
-
Stefan Bürk voted on patch set 7 CR +1 09/04/24, 18:19
-
Garvin Hicking commented on patch set 7 CR +1 V +1 09/04/24, 18:25
I went through these three times in the past days so I feel pretty confident now. Thanks, especially for working out a rector rule! -
Stefan Bürk voted on patch set 7 V +1 09/04/24, 18:27
-
Stefan Bürk voted on patch set 7 CR +2 V +2 09/04/24, 18:28
-
Stefan Bürk merged patch set 8 09/04/24, 18:28