85837[TASK] Update Fluid to 2.15
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Jochen Roth +1
- Garvin Hicking +1
-
Verified V +2 Done
- Simon Praetorius +2
- Jochen Roth +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 10
- typo3/sysext/adminpanel/composer.json+1 −1
- typo3/sysext/core/Documentation/Changelog/13.3/Deprecation-104789-FluidVariablesTrueFalseNull.rst12new+40 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Deprecation-104789-RenderStaticForFluidViewHelpers.rst2new+117 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104789-SupportForContentArgumentNameInAbstractViewHelper.rst2new+56 −0
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/fluid/composer.json+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php6+10 −0
- typo3/sysext/redirects/composer.json+1 −1
- composer.json+1 −1
- composer.lock+6 −6
Review log 1831
Show 36 earlier messages
-
Simon Praetorius uploaded patch set 1 09/01/24, 12:24
-
core-ci voted on patch set 1 V -1 09/01/24, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64600
-
core-ci commented on patch set 1 09/01/24, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64600
-
Simon Praetorius uploaded patch set 2
V -109/01/24, 13:28 -
Simon Praetorius marked it ready for review 09/01/24, 13:28
-
core-ci voted on patch set 2 V -1 09/01/24, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64601
-
core-ci commented on patch set 2 09/01/24, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64601
-
core-ci commented on patch set 2 09/01/24, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64601
-
core-ci voted on patch set 2 V +1 09/01/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64601
-
Garvin Hicking commented on patch set 2 09/01/24, 15:57
Just some minor comments and I'm probably missing the understanding about which fluid version is considered for which TYPO3 version now. (Maybe also establish a "Unreleased experimental Fluid standalone v3 is superseded by a more conservative new major release v4 with an immediate follow-up v5 with breaking changes"; not like that of course, but maybe something for people staring at version numbers and trying to make sense of it ;))Deprecation-104789-FluidVariablesTrueFalseNull.rst:15Could we mention something like "(used in TYPO3 v13)" to make it more clear that it affects this version and not something in the future?Deprecation-104789-FluidVariablesTrueFalseNull.rst:22Use ’{true}' ... here to better indicate what is meant?Deprecation-104789-FluidVariablesTrueFalseNull.rst:24where is this shipped, this is meant to affect v12 versions, right? Maybe add a seperate changelog entry for v12 hinting at this?Deprecation-104789-FluidVariablesTrueFalseNull.rst:30see aboveDeprecation-104789-RenderStaticForFluidViewHelpers.rst:37There's no rector preparation for this to hint at, wasn't there some commit for the core to hint at? Maybe still hint at this probably being an option to perform with tooling more easily?Feature-104789-SupportForContentArgumentNameInAbstractViewHelper.rst:52pet peeve: sounds as if viewhelpers would do that, not integrators 🥸 Maybe "should be considered to be migrated to the new feature"? -
Simon Praetorius uploaded patch set 3
V +109/01/24, 16:35 -
core-ci voted on patch set 3 V -1 09/01/24, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64603
-
Simon Praetorius commented on patch set 3 09/01/24, 16:42
Reply
I've adjusted the commit message a bit to hopefully make this clearer. The goal here is to migrate most of the Fluid-dependent code in the core before releasing and switching to Fluid v4 in order to keep the patches smaller and to avoid one "big bang" patch together with the necessary composer adjustments. There is one major change missing in Fluid main before we can finalize v4 development, so we expect to be able to perform the switch to v4 before the feature freeze.Deprecation-104789-FluidVariablesTrueFalseNull.rst:15ReplyAcknowledgedDeprecation-104789-FluidVariablesTrueFalseNull.rst:22ReplyNot sure if this makes things clearer, because `{true}` is not a variable name and will continue to work in the future.Deprecation-104789-FluidVariablesTrueFalseNull.rst:24ReplyFluid updates are optional for TYPO3 v12, which is why we only update the lock file there. For now, v13 still uses the latest Fluid v2 in order to avoid a huge patch when we switch to v4. A similar phrasing has already been used in another Fluid deprecation RST.Deprecation-104789-FluidVariablesTrueFalseNull.rst:30ReplyI've added "user-defined" here. Hope this makes it a bit clearer.Deprecation-104789-RenderStaticForFluidViewHelpers.rst:37ReplyThere is currently no mention of Rector at all in any changelog file. So this would be a general discussion. Nonetheless the plan is to contribute the existing Rector rule to typo3-rector after the 13.3 release.Feature-104789-SupportForContentArgumentNameInAbstractViewHelper.rst:52ReplyAcknowledged -
core-ci commented on patch set 3 09/01/24, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64603
-
core-ci voted on patch set 3 V +1 09/01/24, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64603
-
Garvin Hicking updated the commit message in patch set 4
V +109/02/24, 06:26 -
Garvin Hicking commented on patch set 5 09/02/24, 06:31
Published edit on patch set 4. -
Garvin Hicking commented on patch set 5 09/02/24, 06:37
Deprecation-104789-FluidVariablesTrueFalseNull.rst:15with the v4 upgrade we'll add a breaking rst for this then, right? The BC impact should be low, using true/false/null for anything else than true/false/null would be odd.ClassNameMatcher.php:2549I would argue "renderStatic" as a method could be relating to viewhelpers most often. Could we accept false positives on this one for the sake of catching VHs to be migrated? -
core-ci voted on patch set 4 V -1 09/02/24, 06:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64618
-
core-ci voted on patch set 5 V -1 09/02/24, 06:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64620
-
Garvin Hicking commented on patch set 5 CR +1 V +1 09/02/24, 07:03
Deprecation-104789-FluidVariablesTrueFalseNull.rst:15ReplyDoneClassNameMatcher.php:2549Replynvm, the problem is the declaration is not matchable, only executions. -
Simon Praetorius commented on patch set 5 09/02/24, 07:04
Deprecation-104789-FluidVariablesTrueFalseNull.rst:15ReplyFrom my point of view, this should be discussed when it IS actually breaking. This patch only adds a deprecation, which will be logged if the user enables the deprecation log.ClassNameMatcher.php:2549ReplyI don't think that this is possible. You would need to find *definitions* (not calls) of `renderStatic()` in arbitrary classes. -
Simon Praetorius commented on patch set 5 09/02/24, 07:06
Deprecation-104789-FluidVariablesTrueFalseNull.rst:15ReplyDoneClassNameMatcher.php:2549ReplyDone -
core-ci commented on patch set 5 09/02/24, 07:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64620
-
core-ci voted on patch set 5 V +1 09/02/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64620
-
Garvin Hicking commented on patch set 5 09/03/24, 11:48
ClassNameMatcher.php:2549ReplySee this sidequest: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85853 -
Jochen Roth voted on patch set 5 CR +1 V +1 09/03/24, 13:14
-
Simon Praetorius commented on patch set 5 09/03/24, 13:15
ClassNameMatcher.php:2549ReplyNice one! I'd suggest we tackle this one once Fluid is merged. -
Simon Praetorius voted on patch set 5 CR +2 V +2 09/03/24, 13:15
-
Simon Praetorius merged patch set 6 09/03/24, 13:15
-
Christian Kuhn commented on patch set 6 09/09/24, 12:53
note these were of course "typo3fluid/fluid:^2.15" calls ;)