Review main Merged

85837[TASK] Update Fluid to 2.15

Simon Praetorius CR +2 V +2 Normal +234 −11 updated 09/09/24, 12:53

Commit message

This release contains important pre-patches for the upgrade to
Fluid v4 in the next step. Apart from soft deprecations of code that
will log deprecation level errors with Fluid v4, it backports a
feature from Fluid v4 to Fluid v2 to deliver a smoother migration
path from Fluid v2 to v4 in 3rd party code. The necessary changes
to TYPO3's ViewHelpers will be applied in a follow-up patch.

Similarly to the previous update to 2.14.0, this patch adds RST
files that describe both new features and deprecations
that were introduced in this version.

Noteworthy changes:

* The functionality of `CompileWithContentArgumentAndRenderStatic`
has been integrated into `AbstractViewHelper` and can thus be used
with non-static ViewHelpers from now on.
* `renderStatic()` and both associated traits
`CompileWithContentArgumentAndRenderStatic` and
`CompileWithRenderStatic` are deprecated
* Methods deprecated with the introduction of the
ViewFactoryInterface in #104773 have been deprecated in Fluid
as well
* `true`, `false` and `null` can no longer be used as variable names,
as these will become proper language keywords in Fluid v4

Executed composer commands:

> composer req typo3fluid/fluid
> composer req -d typo3/sysext/adminpanel --no-update typo3fluid/fluid
> composer req -d typo3/sysext/core --no-update typo3fluid/fluid
> composer req -d typo3/sysext/fluid --no-update typo3fluid/fluid
> composer req -d typo3/sysext/redirects --no-update typo3fluid/fluid

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Jochen Roth +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 3

Files 10

Review log 1831

Show 36 earlier messages
  1. Simon Praetorius uploaded patch set 1 09/01/24, 12:24

  2. core-ci voted on patch set 1 V -1 09/01/24, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64600

  3. core-ci commented on patch set 1 09/01/24, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64600

  4. Simon Praetorius uploaded patch set 2 V -1 09/01/24, 13:28

  5. Simon Praetorius marked it ready for review 09/01/24, 13:28

  6. core-ci voted on patch set 2 V -1 09/01/24, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64601

  1. core-ci commented on patch set 2 09/01/24, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64601

  2. core-ci commented on patch set 2 09/01/24, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64601

  3. core-ci voted on patch set 2 V +1 09/01/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64601

  4. Garvin Hicking commented on patch set 2 09/01/24, 15:57

    Just some minor comments and I'm probably missing the understanding about which fluid version is considered for which TYPO3 version now. (Maybe also establish a "Unreleased experimental Fluid standalone v3 is superseded by a more conservative new major release v4 with an immediate follow-up v5 with breaking changes"; not like that of course, but maybe something for people staring at version numbers and trying to make sense of it ;))

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:15

    Could we mention something like "(used in TYPO3 v13)" to make it more clear that it affects this version and not something in the future?

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:22

    Use ’{true}' ... here to better indicate what is meant?

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:24

    where is this shipped, this is meant to affect v12 versions, right? Maybe add a seperate changelog entry for v12 hinting at this?

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:30

    see above

    Deprecation-104789-RenderStaticForFluidViewHelpers.rst:37

    There's no rector preparation for this to hint at, wasn't there some commit for the core to hint at? Maybe still hint at this probably being an option to perform with tooling more easily?

    Feature-104789-SupportForContentArgumentNameInAbstractViewHelper.rst:52

    pet peeve: sounds as if viewhelpers would do that, not integrators 🥸 Maybe "should be considered to be migrated to the new feature"?
  5. Simon Praetorius uploaded patch set 3 V +1 09/01/24, 16:35

  6. core-ci voted on patch set 3 V -1 09/01/24, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64603

  7. Simon Praetorius commented on patch set 3 09/01/24, 16:42

    Reply

    I've adjusted the commit message a bit to hopefully make this clearer. The goal here is to migrate most of the Fluid-dependent code in the core before releasing and switching to Fluid v4 in order to keep the patches smaller and to avoid one "big bang" patch together with the necessary composer adjustments. There is one major change missing in Fluid main before we can finalize v4 development, so we expect to be able to perform the switch to v4 before the feature freeze.

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:15 Reply

    Acknowledged

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:22 Reply

    Not sure if this makes things clearer, because `{true}` is not a variable name and will continue to work in the future.

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:24 Reply

    Fluid updates are optional for TYPO3 v12, which is why we only update the lock file there. For now, v13 still uses the latest Fluid v2 in order to avoid a huge patch when we switch to v4. A similar phrasing has already been used in another Fluid deprecation RST.

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:30 Reply

    I've added "user-defined" here. Hope this makes it a bit clearer.

    Deprecation-104789-RenderStaticForFluidViewHelpers.rst:37 Reply

    There is currently no mention of Rector at all in any changelog file. So this would be a general discussion. Nonetheless the plan is to contribute the existing Rector rule to typo3-rector after the 13.3 release.

    Feature-104789-SupportForContentArgumentNameInAbstractViewHelper.rst:52 Reply

    Acknowledged
  8. core-ci commented on patch set 3 09/01/24, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64603

  9. core-ci voted on patch set 3 V +1 09/01/24, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64603

  10. Garvin Hicking updated the commit message in patch set 4 V +1 09/02/24, 06:26

  11. Garvin Hicking commented on patch set 5 09/02/24, 06:31

    Published edit on patch set 4.
  12. Garvin Hicking commented on patch set 5 09/02/24, 06:37

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:15

    with the v4 upgrade we'll add a breaking rst for this then, right? The BC impact should be low, using true/false/null for anything else than true/false/null would be odd.

    ClassNameMatcher.php:2549

    I would argue "renderStatic" as a method could be relating to viewhelpers most often. Could we accept false positives on this one for the sake of catching VHs to be migrated?
  13. core-ci voted on patch set 4 V -1 09/02/24, 06:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64618

  14. core-ci voted on patch set 5 V -1 09/02/24, 06:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64620

  15. Garvin Hicking commented on patch set 5 CR +1 V +1 09/02/24, 07:03

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:15 Reply

    Done

    ClassNameMatcher.php:2549 Reply

    nvm, the problem is the declaration is not matchable, only executions.
  16. Simon Praetorius commented on patch set 5 09/02/24, 07:04

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:15 Reply

    From my point of view, this should be discussed when it IS actually breaking. This patch only adds a deprecation, which will be logged if the user enables the deprecation log.

    ClassNameMatcher.php:2549 Reply

    I don't think that this is possible. You would need to find *definitions* (not calls) of `renderStatic()` in arbitrary classes.
  17. Simon Praetorius commented on patch set 5 09/02/24, 07:06

    Deprecation-104789-FluidVariablesTrueFalseNull.rst:15 Reply

    Done

    ClassNameMatcher.php:2549 Reply

    Done
  18. core-ci commented on patch set 5 09/02/24, 07:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64620

  19. core-ci voted on patch set 5 V +1 09/02/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64620

  20. Garvin Hicking commented on patch set 5 09/03/24, 11:48

    ClassNameMatcher.php:2549 Reply

  21. Jochen Roth voted on patch set 5 CR +1 V +1 09/03/24, 13:14

  22. Simon Praetorius commented on patch set 5 09/03/24, 13:15

    ClassNameMatcher.php:2549 Reply

    Nice one! I'd suggest we tackle this one once Fluid is merged.
  23. Simon Praetorius voted on patch set 5 CR +2 V +2 09/03/24, 13:15

  24. Simon Praetorius merged patch set 6 09/03/24, 13:15

  25. Christian Kuhn commented on patch set 6 09/09/24, 12:53

    note these were of course "typo3fluid/fluid:^2.15" calls ;)