Review 12.4 Merged

85838[TASK] Update Fluid to 2.15

Simon Praetorius CR +2 V +2 Easy +5 −5 updated 09/04/24, 05:43

Commit message

Apart from soft deprecations and a backport feature, this release
logs a deprecation level error message if `true`, `false` or `null`
are used as template variable names. `@` operator is used, so
deprecation output is suppressed.

Executed command:

> composer update typo3fluid/fluid

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 711

  1. Simon Praetorius uploaded patch set 1 09/01/24, 13:42

  2. core-ci voted on patch set 1 V -1 09/01/24, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64602

  3. core-ci voted on patch set 1 V +1 09/01/24, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64602

  4. Simon Praetorius updated the commit message in patch set 2 V +1 09/01/24, 17:03

  5. core-ci voted on patch set 2 V -1 09/01/24, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64604

  6. core-ci voted on patch set 2 V +1 09/01/24, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64604

  7. Benni Mack commented on patch set 2 09/02/24, 05:44

    Hey, this would mean that my project now might log / throw deprecations just by upgrading the minor version, correct?
  8. Simon Praetorius commented on patch set 2 09/02/24, 06:21

    Reply

    If you enable the deprecation log in your instance's configuration and you use `true`, `false` or `null` as Fluid variable names, new log entries in the deprecation log file will be created. I just verified this with my site: Config: $GLOBALS['TYPO3_CONF_VARS']['LOG']['TYPO3']['CMS']['deprecations'] ['writerConfiguration'][TYPO3\CMS\Core\Log\LogLevel::NOTICE][TYPO3\CMS\Core\Log\Writer\FileWriter::class] ['disabled'] = false; TypoScript: 10 = FLUIDTEMPLATE 10.variables.true = 1 Log: Mon, 02 Sep 2024 06:18:05 +0000 [NOTICE] request="d000ad1174344" component="TYPO3.CMS.deprecations": Core: Error handler (FE): TYPO3 Deprecation Notice: The specified variable identifier "true" will no longer be allowed in Fluid v4. in /var/www/html/vendor/typo3fluid/fluid/src/Core/Variables/StandardVariableProvider.php line 107
  9. Garvin Hicking commented on patch set 2 CR +1 V +1 09/03/24, 12:25

    Reply

    I would argue this true/false/null variable assignment change is a bugfix, and adding a deprecation notice for it is "lending a helping hand" for consumers to get aware of this. Deprecation logging IMO shouldn't be done in prod, so I think this does more good than bad to backport this one.
  10. Benni Mack voted on patch set 2 CR +2 V +2 09/04/24, 05:43

  11. Benni Mack merged patch set 3 09/04/24, 05:43