Review main Merged

85852[TASK] Add helper method to create custom record types

Benni Mack CR +2 V +2 Expert +506 −730 updated 10/07/24, 13:45

Commit message

This change adds a new method called
"ExtensionManagementUtility::addRecordType()"
which allows developers to add custom types
for any TCA table which supports types.

An "extended" tab is added automatically,
if it does not exist yet.

This change aims to reduce accessing and modifying
$GLOBALS[TCA] in Configuration/TCA/Overrides as much
as possible.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 3053

Show 1428 earlier messages
  1. Benni Mack uploaded patch set 1 09/03/24, 09:06

  2. core-ci voted on patch set 1 V -1 09/03/24, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64655

  3. Oli Bartsch uploaded patch set 2 V -1 09/03/24, 09:48

  4. core-ci voted on patch set 2 V -1 09/03/24, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64657

  5. Oli Bartsch uploaded patch set 3 V -1 09/03/24, 10:18

  6. core-ci voted on patch set 3 V -1 09/03/24, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64658

  7. Oli Bartsch uploaded patch set 4 V -1 09/03/24, 10:42

  8. core-ci voted on patch set 4 V -1 09/03/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64659

  9. Benni Mack uploaded patch set 5 V -1 09/09/24, 19:14

  10. core-ci voted on patch set 5 V +1 09/09/24, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65138

  11. Benni Mack uploaded patch set 6 V +1 09/10/24, 09:23

  12. core-ci voted on patch set 6 V -1 09/10/24, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65198

  13. Benni Mack uploaded patch set 7 V -1 09/10/24, 10:10

  14. core-ci voted on patch set 7 V +1 09/10/24, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65208

  15. Benni Mack uploaded patch set 8 V +1 09/10/24, 19:50

  16. Benni Mack uploaded patch set 9 09/10/24, 19:53

  17. core-ci voted on patch set 8 V -1 09/10/24, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65330

  18. core-ci voted on patch set 9 V -1 09/10/24, 20:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65332

  19. Benni Mack uploaded patch set 10 V -1 09/10/24, 20:33

  20. core-ci voted on patch set 10 V -1 09/10/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65349

  21. Benni Mack uploaded patch set 11 V -1 09/10/24, 21:11

  22. core-ci voted on patch set 11 V -1 09/10/24, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65355

  23. Benni Mack commented on patch set 12 V -1 09/11/24, 11:49

    Published edit on patch set 11.
  24. core-ci voted on patch set 12 V -1 09/11/24, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65426

  25. Benni Mack uploaded patch set 13 V -1 09/11/24, 12:30

  26. core-ci voted on patch set 13 V +1 09/11/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65437

  27. Benni Mack uploaded patch set 14 V +1 09/11/24, 13:17

  28. core-ci voted on patch set 14 V +1 09/11/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65451

  1. Benni Mack uploaded patch set 15 V +1 09/11/24, 13:36

  2. Nikita Hovratov commented on patch set 15 09/11/24, 13:40

    ExtensionManagementUtility.php:892

    str_contains(...) === false maybe better suited?
  3. core-ci voted on patch set 15 V +1 09/11/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65454

  4. Nikita Hovratov commented on patch set 15 09/11/24, 13:48

    ExtensionManagementUtility.php:877

    Please rephrase to "Can't add record type {recordType} for table {table} without type field defined" or something like that. So it is clear, what the reason is for the exception.

    ExtensionManagementUtility.php:881

    instead of !isset we can make use of ??= operator
  5. Benni Mack uploaded patch set 16 V +1 09/11/24, 18:57

  6. core-ci voted on patch set 16 V -1 09/11/24, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65479

  7. Benni Mack uploaded patch set 17 V -1 09/11/24, 19:58

  8. core-ci voted on patch set 17 V +1 09/11/24, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65488

  9. Benni Mack commented on patch set 18 V +1 09/12/24, 08:14

    Published edit on patch set 17.
  10. Benni Mack commented on patch set 18 09/12/24, 08:14

    ExtensionManagementUtility.php:877 Reply

    Done

    ExtensionManagementUtility.php:881 Reply

    Done

    ExtensionManagementUtility.php:892 Reply

    Done
  11. core-ci voted on patch set 18 V +1 09/12/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65538

  12. Benni Mack updated the commit message in patch set 19 V +1 09/12/24, 13:10

  13. core-ci voted on patch set 19 V +1 09/12/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65564

  14. Benni Mack uploaded patch set 20 V +1 09/30/24, 12:21

  15. core-ci voted on patch set 20 V +1 09/30/24, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66853

  16. Oli Bartsch uploaded patch set 21 V +1 10/04/24, 12:43

  17. Oli Bartsch uploaded patch set 22 10/04/24, 12:47

  18. core-ci voted on patch set 21 V -1 10/04/24, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67086

  19. core-ci voted on patch set 22 V -1 10/04/24, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67088

  20. Oli Bartsch uploaded patch set 23 V -1 10/04/24, 13:01

  21. core-ci voted on patch set 23 V +1 10/04/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67092

  22. Oli Bartsch voted on patch set 23 CR +1 V +1 10/04/24, 15:38

  23. Christian Kuhn voted on patch set 23 CR +1 V +1 10/07/24, 13:42

  24. Benni Mack voted on patch set 23 CR +2 V +2 10/07/24, 13:44

  25. Benni Mack merged patch set 24 10/07/24, 13:45