85853[TASK] Add AbstractMethodImplementationMatcher to extension scanner
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Simon Praetorius +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Simon Praetorius +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/install/Classes/Controller/UpgradeController.php+5 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/AbstractMethodImplementationMatcher.php7new+148 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/AbstractMethodImplementationMatcher.phpnew+10 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/AbstractMethodImplementationMatcherFixture.phpnew+101 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/AbstractMethodImplementationMatcherTest.php2new+94 −0
Review log 2636
Show 711 earlier messages
-
Garvin Hicking uploaded patch set 1 09/03/24, 11:37
-
Garvin Hicking uploaded patch set 2 09/03/24, 11:40
-
Garvin Hicking commented on patch set 2 09/03/24, 11:41
NOTE: To test this, please adapt `typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodDefinitionMatcher.php` and enter an existing ReST file name there. Check out the screenshot in the issue how a match looks like. -
core-ci voted on patch set 1 V -1 09/03/24, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64661
-
core-ci voted on patch set 2 V -1 09/03/24, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64662
-
Garvin Hicking uploaded patch set 3
V -109/03/24, 12:18Use a dummy for ReST matching -
core-ci voted on patch set 3 V -1 09/03/24, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64665
-
Garvin Hicking uploaded patch set 4
V -109/03/24, 12:46Proper type usage -
core-ci voted on patch set 4 V -1 09/03/24, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64668
-
Garvin Hicking uploaded patch set 5
V -109/03/24, 13:53Adjust to merged fluid patch -
Garvin Hicking commented on patch set 5 09/03/24, 13:53
Reply
With the merge of https://review.typo3.org/c/Packages/TYPO3.CMS/+/85837 the ReST file is not properly aligned.
-
Garvin Hicking commented on patch set 5 09/03/24, 13:54
Reply
s/not/now/ -
core-ci voted on patch set 5 V -1 09/03/24, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64670
-
core-ci commented on patch set 5 09/03/24, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64670
-
Simon Praetorius commented on patch set 5 09/03/24, 17:31
MethodDefinitionMatcher.php:29How about naming it `AbstractMethodImplementationMatcher`? Other than that: LGTM! -
Garvin Hicking uploaded patch set 6
V -109/04/24, 13:20 -
Garvin Hicking commented on patch set 6 09/04/24, 13:20
MethodDefinitionMatcher.php:29ReplyDone -
core-ci voted on patch set 6 V -1 09/04/24, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64757
-
Garvin Hicking uploaded patch set 7
V -109/04/24, 13:28 -
core-ci voted on patch set 7 V +1 09/04/24, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64758
-
Garvin Hicking updated the commit message in patch set 8
V +109/04/24, 13:39 -
core-ci voted on patch set 8 V +1 09/04/24, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64759
-
Simon Praetorius commented on patch set 8 09/04/24, 13:52
AbstractMethodImplementationMatcherTest.php:76I think a slash is missing here (and below as well) -
Garvin Hicking uploaded patch set 9
V +109/04/24, 14:01 -
Garvin Hicking commented on patch set 9 09/04/24, 14:01
AbstractMethodImplementationMatcherTest.php:76ReplyDone -
core-ci voted on patch set 9 V +1 09/04/24, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64766
-
Simon Praetorius voted on patch set 9 CR +1 V +1 09/04/24, 14:13
-
Simon Schaufelberger commented on patch set 9 09/11/24, 09:51
AbstractMethodImplementationMatcher.php:106too much nesting going on here. please use early return instead -
Simon Schaufelberger commented on patch set 9 09/11/24, 09:53
AbstractMethodImplementationMatcher.php:106Replyin Rector we use shouldSkip method for that to combine this checks -
Garvin Hicking commented on patch set 9 09/11/24, 09:54
AbstractMethodImplementationMatcher.php:106ReplyThanks for checking this out. I respectfully disagree, this is in line with the way all the other matchers do that, and I'd rather have similar code than one element stand out. See typo3/sysext/install/Classes/ExtensionScanner/Php/GeneratorClassesResolver.php for example. -
Simon Schaufelberger commented on patch set 9 09/11/24, 09:54
AbstractMethodImplementationMatcher.php:106Reply``` if ($this->shouldSkip($node)) { return null; } ``` -
Garvin Hicking commented on patch set 9 09/11/24, 10:24
AbstractMethodImplementationMatcher.php:106ReplyAcknowledged -
Garvin Hicking commented on patch set 9 09/11/24, 10:25
AbstractMethodImplementationMatcher.php:106ReplyIf you want, you could address this in a follow-up patch and introduce such a method consistently for all matchers? I'd like to keep this out of scope for this PR. -
Simon Schaufelberger commented on patch set 9 CR +1 V +1 09/11/24, 10:39
AbstractMethodImplementationMatcher.php:106Replyok -
Garvin Hicking voted on patch set 9 CR +2 V +2 09/12/24, 09:04
-
Garvin Hicking merged patch set 10 09/12/24, 09:04