Review main Merged

85854[TASK] Cleanup Redis classes

Markus Klein CR +2 V +2 Normal +76 −82 updated 09/04/24, 18:46

Commit message

Add more typehints and introduce helper methods
to make the code more readable.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Markus Klein uploaded patch set 1 09/03/24, 11:51

  2. Nikita Hovratov voted on patch set 1 CR +1 09/03/24, 12:08

  3. core-ci voted on patch set 1 V -1 09/03/24, 12:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64663

  4. core-ci voted on patch set 1 V +1 09/03/24, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64663

  5. Garvin Hicking voted on patch set 1 CR +1 09/03/24, 12:48

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/03/24, 14:48

  7. Guido Schmechel voted on patch set 1 CR +1 09/03/24, 19:13

  8. Stefan Bürk voted on patch set 1 CR +2 V +2 09/04/24, 18:46

  9. Stefan Bürk merged patch set 2 09/04/24, 18:46