Review main Abandoned

85857[TASK] Automatically add system fields to tt_content

Benni Mack CR 0 V 0 Hard +47 −299 updated 09/04/24, 11:39

Commit message

Certain fields are now added to tt_content, which
can never be removed, as they are declared system fields.

This way, defining custom content types is much easier.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 34

  1. Benni Mack uploaded patch set 1 09/03/24, 14:50

  2. core-ci voted on patch set 1 V -1 09/03/24, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64674

  3. Mathias Brodala commented on patch set 1 09/03/24, 15:14

    TcaPreparation.php:396 Unresolved

    Can we use a herestring instead here? Or the common implode() pattern? The result is cached anyways. CSV strings are well-known to be evil. ;-)
  4. Benni Mack abandoned the change 09/04/24, 11:39

    I think we'll continue with a more lightweight approach from Nikita