Review main Merged

85859[FEATURE] Auto-add system fields showitem for tt_content

Nikita Hovratov CR +2 V +2 Expert +980 −209 updated 09/05/24, 08:26

Commit message

This change adds system fields - as defined in the ctrl
section - of tt_content to the showitem field list
automatically. This is either done based on palettes
that already exist or adding the fields individually
to the corresponding tabs.

Tabs that are therefore added automatically are:

* General tab at the beginning
* Language tab including language fields
* Access tab including hidden+access fields
* Description tab including descriptionColumn

In case the showitem of such type defines the
"Extended" tab, it is added at the end.

We do this for tt_content because we want a unified
way of how FormEngine renders the fields.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 4768

Show 2843 earlier messages
  1. Nikita Hovratov uploaded patch set 1 09/03/24, 16:30

  2. core-ci voted on patch set 1 V -1 09/03/24, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64687

  3. Benni Mack uploaded patch set 2 V -1 09/04/24, 07:08

  4. Benni Mack uploaded patch set 3 09/04/24, 07:09

  5. core-ci voted on patch set 3 V -1 09/04/24, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64720

  6. core-ci voted on patch set 2 V -1 09/04/24, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64719

  7. Benni Mack uploaded patch set 4 V -1 09/04/24, 09:09

  8. Benni Mack uploaded patch set 5 09/04/24, 09:24

  9. core-ci voted on patch set 4 V -1 09/04/24, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64732

  10. core-ci voted on patch set 5 V -1 09/04/24, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64737

  11. Benni Mack uploaded patch set 6 V -1 09/04/24, 09:52

  12. core-ci voted on patch set 6 V +1 09/04/24, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64741

  13. Oli Bartsch uploaded patch set 7 V +1 09/04/24, 13:49

  14. core-ci voted on patch set 7 V +1 09/04/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64761

  15. Nikita Hovratov commented on patch set 7 09/04/24, 14:25

    TcaPreparation.php:528

    Hey, we discussed to not touch categories, as this is a custom field/tab. I would just let it in the position, where it was defined by the user. Does extended need to be at the end for addTcaColumnsToTypes to work?
  16. Oli Bartsch uploaded patch set 8 V +1 09/04/24, 15:17

  17. core-ci voted on patch set 8 V +1 09/04/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64774

  18. Benni Mack commented on patch set 8 09/04/24, 15:35

    TcaPreparation.php:528 Reply

    I assume this is convenience, although I personally do not care where the Categories tab is positioned I personally would love to have the extended tab added automatically, but I assume this is another topic and not possible for v13.

    TcaPreparationTest.php:885

    can we have one case where there is an existing field in a custom defined showitem (e.g. rowDescription) but with a custom label "rowDescription;myLabel" so it gets removed (and then re-added) as well?

    TcaPreparationTest.php:967

    "keept" => "kept"
  19. Oli Bartsch uploaded patch set 9 V +1 09/04/24, 16:23

  20. Oli Bartsch uploaded patch set 10 09/04/24, 16:29

  21. Oli Bartsch commented on patch set 9 09/04/24, 16:30

    TcaPreparation.php:528 Reply

    The functionality would have added the categories tab always after the general tab / palette, because this is where all the showitem content is instered. It's therefore not possible to keep any user defined position so I think it's better to add it at the place where it has been placed by core like before. Regarding the extended tab. Exactly, we need it for `addToAllTcaTypes()`. It does not necessarily have to be added at the end. However this is common behaviour currently and would otherwise lead to the situation that this tab might be added at different positions, depending on the combination of the dedicated types definition and ctrl.

    TcaPreparationTest.php:885 Reply

    Done

    TcaPreparationTest.php:967 Reply

    Done
  22. Oli Bartsch uploaded patch set 11 09/04/24, 16:34

  23. core-ci voted on patch set 9 V -1 09/04/24, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64790

  24. core-ci voted on patch set 11 V +1 09/04/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64794

  25. Oli Bartsch uploaded patch set 12 V +1 09/04/24, 16:47

  26. core-ci voted on patch set 12 V -1 09/04/24, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64796

  27. Benni Mack uploaded patch set 13 V -1 09/04/24, 16:56

  28. Oli Bartsch uploaded patch set 14 09/04/24, 17:00

  29. Oli Bartsch uploaded patch set 15 09/04/24, 17:02

  30. core-ci voted on patch set 15 V +1 09/04/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64800

  31. Oli Bartsch uploaded patch set 16 V +1 09/04/24, 17:10

  32. Oli Bartsch voted on patch set 16 CR +1 V +1 09/04/24, 17:10

  33. Nikita Hovratov commented on patch set 16 09/04/24, 17:11

    TcaPreparation.php:528 Reply

    Done
  34. Nikita Hovratov voted on patch set 16 V +1 09/04/24, 17:11

  35. core-ci voted on patch set 16 V +1 09/04/24, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64801

  36. Nikita Hovratov commented on patch set 16 09/04/24, 17:33

    TcaPreparation.php:439

    from

    TcaPreparation.php:464

    This looks like it needs to be checked more strictly with array parts, instead of an occurrence of the string.

    TcaPreparation.php:563

    please check for full --div-- or --palette--
  37. Nikita Hovratov commented on patch set 16 09/04/24, 17:40

    Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:49

    This sentence reads a bit clunky.

    Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:55

    removed
  38. Nikita Hovratov commented on patch set 16 09/04/24, 17:59

    TcaPreparation.php:467

    Suggestion: So it was always possible to define an own, custom first tab. If not defined, FormEngine already creates the general tab for you! My suggestion is to check, whether the first item is a tab, if so keep it. And then the general tab can be removed completely from this definition here. Per default, we start with the "general" palette.
  39. Oli Bartsch uploaded patch set 17 CR +1 V +1 09/04/24, 20:52

  40. core-ci voted on patch set 17 V +1 09/04/24, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64813

  41. Benni Mack uploaded patch set 18 V +1 09/04/24, 21:10

  42. Benni Mack commented on patch set 18 09/04/24, 21:11

    TcaPreparation.php:467 Reply

    Done
  43. core-ci voted on patch set 18 V +1 09/04/24, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64814

  1. Oli Bartsch uploaded patch set 19 V +1 09/04/24, 21:58

  2. Oli Bartsch uploaded patch set 20 09/04/24, 22:02

  3. core-ci voted on patch set 19 V -1 09/04/24, 22:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64815

  4. Oli Bartsch commented on patch set 20 09/04/24, 22:02

    TcaPreparation.php:439 Reply

    Done

    TcaPreparation.php:464 Reply

    Done

    TcaPreparation.php:563 Reply

    Done

    Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:49 Reply

    Done

    Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:55 Reply

    Done
  5. Oli Bartsch uploaded patch set 21 09/04/24, 22:05

  6. core-ci voted on patch set 20 V -1 09/04/24, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64816

  7. core-ci voted on patch set 21 V +1 09/04/24, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64819

  8. Oli Bartsch voted on patch set 21 CR +1 V +1 09/04/24, 22:15

  9. Oli Bartsch commented on patch set 21 V 0 CR -1 09/04/24, 22:35

    Need to check some details.
  10. Nikita Hovratov commented on patch set 21 09/05/24, 06:54

    Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:54

    added
  11. Oli Bartsch uploaded patch set 22 CR -1 V +1 09/05/24, 07:51

  12. core-ci voted on patch set 22 V +1 09/05/24, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64841

  13. Oli Bartsch uploaded patch set 23 V +1 09/05/24, 08:05

  14. Oli Bartsch commented on patch set 23 CR +1 V +1 09/05/24, 08:05

    Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:54 Reply

    Done
  15. Oli Bartsch commented on patch set 23 09/05/24, 08:10

    Reply

    Done
  16. core-ci voted on patch set 23 V +1 09/05/24, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64843

  17. Benni Mack voted on patch set 23 CR +1 V +1 09/05/24, 08:11

  18. Nikita Hovratov commented on patch set 23 09/05/24, 08:14

    Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:21

    double are in this sentence
  19. Benni Mack commented on patch set 24 CR +1 V +1 09/05/24, 08:17

    Published edit on patch set 23.
  20. Benni Mack commented on patch set 24 CR +1 V +1 09/05/24, 08:18

    Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:21 Reply

    Done
  21. Nikita Hovratov voted on patch set 24 CR +1 V +1 09/05/24, 08:18

  22. Oli Bartsch voted on patch set 24 CR +1 V +1 09/05/24, 08:19

  23. core-ci voted on patch set 24 V +1 09/05/24, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64844

  24. Oli Bartsch voted on patch set 24 CR +2 V +2 09/05/24, 08:26

  25. Oli Bartsch merged patch set 25 09/05/24, 08:26