85859[FEATURE] Auto-add system fields showitem for tt_content
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Configuration/Tca/TcaPreparation.php12+193 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst8new+128 −0
- typo3/sysext/core/Tests/Functional/Schema/TcaSchemaTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaPreparationTest.php4+657 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+1 −208
Review log 4768
Show 2843 earlier messages
-
Nikita Hovratov uploaded patch set 1 09/03/24, 16:30
-
core-ci voted on patch set 1 V -1 09/03/24, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64687
-
Benni Mack uploaded patch set 2
V -109/04/24, 07:08 -
Benni Mack uploaded patch set 3 09/04/24, 07:09
-
core-ci voted on patch set 3 V -1 09/04/24, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64720
-
core-ci voted on patch set 2 V -1 09/04/24, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64719
-
Benni Mack uploaded patch set 4
V -109/04/24, 09:09 -
Benni Mack uploaded patch set 5 09/04/24, 09:24
-
core-ci voted on patch set 4 V -1 09/04/24, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64732
-
core-ci voted on patch set 5 V -1 09/04/24, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64737
-
Benni Mack uploaded patch set 6
V -109/04/24, 09:52 -
core-ci voted on patch set 6 V +1 09/04/24, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64741
-
Oli Bartsch uploaded patch set 7
V +109/04/24, 13:49 -
core-ci voted on patch set 7 V +1 09/04/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64761
-
Nikita Hovratov commented on patch set 7 09/04/24, 14:25
-
Oli Bartsch uploaded patch set 8
V +109/04/24, 15:17 -
core-ci voted on patch set 8 V +1 09/04/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64774
-
Benni Mack commented on patch set 8 09/04/24, 15:35
TcaPreparation.php:528ReplyI assume this is convenience, although I personally do not care where the Categories tab is positioned I personally would love to have the extended tab added automatically, but I assume this is another topic and not possible for v13.TcaPreparationTest.php:885can we have one case where there is an existing field in a custom defined showitem (e.g. rowDescription) but with a custom label "rowDescription;myLabel" so it gets removed (and then re-added) as well?TcaPreparationTest.php:967"keept" => "kept" -
Oli Bartsch uploaded patch set 9
V +109/04/24, 16:23 -
Oli Bartsch uploaded patch set 10 09/04/24, 16:29
-
Oli Bartsch commented on patch set 9 09/04/24, 16:30
TcaPreparation.php:528ReplyThe functionality would have added the categories tab always after the general tab / palette, because this is where all the showitem content is instered. It's therefore not possible to keep any user defined position so I think it's better to add it at the place where it has been placed by core like before. Regarding the extended tab. Exactly, we need it for `addToAllTcaTypes()`. It does not necessarily have to be added at the end. However this is common behaviour currently and would otherwise lead to the situation that this tab might be added at different positions, depending on the combination of the dedicated types definition and ctrl.TcaPreparationTest.php:885ReplyDoneTcaPreparationTest.php:967ReplyDone -
Oli Bartsch uploaded patch set 11 09/04/24, 16:34
-
core-ci voted on patch set 9 V -1 09/04/24, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64790
-
core-ci voted on patch set 11 V +1 09/04/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64794
-
Oli Bartsch uploaded patch set 12
V +109/04/24, 16:47 -
core-ci voted on patch set 12 V -1 09/04/24, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64796
-
Benni Mack uploaded patch set 13
V -109/04/24, 16:56 -
Oli Bartsch uploaded patch set 14 09/04/24, 17:00
-
Oli Bartsch uploaded patch set 15 09/04/24, 17:02
-
core-ci voted on patch set 15 V +1 09/04/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64800
-
Oli Bartsch uploaded patch set 16
V +109/04/24, 17:10 -
Oli Bartsch voted on patch set 16 CR +1 V +1 09/04/24, 17:10
-
Nikita Hovratov commented on patch set 16 09/04/24, 17:11
TcaPreparation.php:528ReplyDone -
Nikita Hovratov voted on patch set 16 V +1 09/04/24, 17:11
-
core-ci voted on patch set 16 V +1 09/04/24, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64801
-
Nikita Hovratov commented on patch set 16 09/04/24, 17:33
TcaPreparation.php:439fromTcaPreparation.php:464This looks like it needs to be checked more strictly with array parts, instead of an occurrence of the string.TcaPreparation.php:563please check for full --div-- or --palette-- -
Nikita Hovratov commented on patch set 16 09/04/24, 17:40
Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:49This sentence reads a bit clunky.Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:55removed -
Nikita Hovratov commented on patch set 16 09/04/24, 17:59
TcaPreparation.php:467Suggestion: So it was always possible to define an own, custom first tab. If not defined, FormEngine already creates the general tab for you! My suggestion is to check, whether the first item is a tab, if so keep it. And then the general tab can be removed completely from this definition here. Per default, we start with the "general" palette. -
Oli Bartsch uploaded patch set 17
CR +1V +109/04/24, 20:52 -
core-ci voted on patch set 17 V +1 09/04/24, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64813
-
Benni Mack uploaded patch set 18
V +109/04/24, 21:10 -
Benni Mack commented on patch set 18 09/04/24, 21:11
TcaPreparation.php:467ReplyDone -
core-ci voted on patch set 18 V +1 09/04/24, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64814
-
Oli Bartsch uploaded patch set 19
V +109/04/24, 21:58 -
Oli Bartsch uploaded patch set 20 09/04/24, 22:02
-
core-ci voted on patch set 19 V -1 09/04/24, 22:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64815
-
Oli Bartsch commented on patch set 20 09/04/24, 22:02
TcaPreparation.php:439ReplyDoneTcaPreparation.php:464ReplyDoneTcaPreparation.php:563ReplyDoneFeature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:49ReplyDoneFeature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:55ReplyDone -
Oli Bartsch uploaded patch set 21 09/04/24, 22:05
-
core-ci voted on patch set 20 V -1 09/04/24, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64816
-
core-ci voted on patch set 21 V +1 09/04/24, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64819
-
Oli Bartsch voted on patch set 21 CR +1 V +1 09/04/24, 22:15
-
Oli Bartsch commented on patch set 21 V 0 CR -1 09/04/24, 22:35
Need to check some details. -
Nikita Hovratov commented on patch set 21 09/05/24, 06:54
Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:54added -
Oli Bartsch uploaded patch set 22
CR -1V +109/05/24, 07:51 -
core-ci voted on patch set 22 V +1 09/05/24, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64841
-
Oli Bartsch uploaded patch set 23
V +109/05/24, 08:05 -
Oli Bartsch commented on patch set 23 CR +1 V +1 09/05/24, 08:05
Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:54ReplyDone -
Oli Bartsch commented on patch set 23 09/05/24, 08:10
Reply
Done -
core-ci voted on patch set 23 V +1 09/05/24, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64843
-
Benni Mack voted on patch set 23 CR +1 V +1 09/05/24, 08:11
-
Nikita Hovratov commented on patch set 23 09/05/24, 08:14
Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:21double are in this sentence -
Benni Mack commented on patch set 24
CR +1V +109/05/24, 08:17Published edit on patch set 23. -
Benni Mack commented on patch set 24 CR +1 V +1 09/05/24, 08:18
Feature-104814-AutomaticallyAddSystemFieldsToContentTypes.rst:21ReplyDone -
Nikita Hovratov voted on patch set 24 CR +1 V +1 09/05/24, 08:18
-
Oli Bartsch voted on patch set 24 CR +1 V +1 09/05/24, 08:19
-
core-ci voted on patch set 24 V +1 09/05/24, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64844
-
Oli Bartsch voted on patch set 24 CR +2 V +2 09/05/24, 08:26
-
Oli Bartsch merged patch set 25 09/05/24, 08:26
TcaPreparation.php:528