85861[TASK] Avoid deprecated fillFromConfigurationArray()
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Markus Klein +1
- Stefan Bürk +1
-
Verified V +2 Done
- Simon Praetorius +2
- Markus Klein +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1318
-
Simon Praetorius uploaded patch set 1 09/03/24, 18:10
-
core-ci voted on patch set 1 V -1 09/03/24, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64693
-
Simon Praetorius uploaded patch set 2
V -109/03/24, 18:29 -
core-ci voted on patch set 2 V -1 09/03/24, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64694
-
core-ci commented on patch set 2 09/04/24, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64694
-
Simon Praetorius uploaded patch set 3
V -109/04/24, 17:46 -
Simon Praetorius uploaded patch set 4 09/04/24, 17:49
-
Simon Praetorius marked it ready for review 09/04/24, 17:50
-
core-ci voted on patch set 3 V +1 09/04/24, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64802
-
core-ci voted on patch set 4 V +1 09/04/24, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64803
-
Markus Klein voted on patch set 4 CR +1 09/04/24, 20:09
-
Stefan Bürk voted on patch set 4 CR +1 V +1 09/04/24, 20:16
-
Markus Klein commented on patch set 4 09/04/24, 20:29
-
Stefan Bürk commented on patch set 4 09/04/24, 20:56
FormEditorController.php:433ReplyFormat is not documented for ext:form formEditorFluidConfiguration: https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Config/proto/formEditor/Index.html#prototypes.prototypeIdentifier.formeditor.formeditorfluidconfiguration So it may be breaking for people using it, but I postulate that this was never intendet here and thus working by "accident". What do you think ? -
Markus Klein commented on patch set 4 V +1 09/05/24, 06:59
FormEditorController.php:433ReplyFull Ack! -
Simon Praetorius commented on patch set 4 09/05/24, 07:00
FormEditorController.php:433ReplyYes, you're right, it would be possible to set this. One more reason why we need to get rid of these magic configuration methods... I tend to agree with Stefan that we shouldn't support this anymore since it's not documented. It's also not part of the default FormSetup.yaml, which would be the place where I would look for possible options. -
Simon Praetorius commented on patch set 4 CR +2 V +2 09/05/24, 07:09
FormEditorController.php:433ReplyAcknowledged -
Simon Praetorius merged patch set 5 09/05/24, 07:09
FormEditorController.php:433