Review main Merged

85861[TASK] Avoid deprecated fillFromConfigurationArray()

Simon Praetorius CR +2 V +2 Easy +13 −6 updated 09/05/24, 07:09

Commit message

`fillFromConfigurationArray()` has been deprecated with
Fluid v2.15. Instead, we use the new ViewFactory to create
a Fluid view.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Markus Klein +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Markus Klein +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1318

  1. Simon Praetorius uploaded patch set 1 09/03/24, 18:10

  2. core-ci voted on patch set 1 V -1 09/03/24, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64693

  3. Simon Praetorius uploaded patch set 2 V -1 09/03/24, 18:29

  4. core-ci voted on patch set 2 V -1 09/03/24, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64694

  5. core-ci commented on patch set 2 09/04/24, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64694

  6. Simon Praetorius uploaded patch set 3 V -1 09/04/24, 17:46

  7. Simon Praetorius uploaded patch set 4 09/04/24, 17:49

  8. Simon Praetorius marked it ready for review 09/04/24, 17:50

  9. core-ci voted on patch set 3 V +1 09/04/24, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64802

  10. core-ci voted on patch set 4 V +1 09/04/24, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64803

  11. Markus Klein voted on patch set 4 CR +1 09/04/24, 20:09

  12. Stefan Bürk voted on patch set 4 CR +1 V +1 09/04/24, 20:16

  13. Markus Klein commented on patch set 4 09/04/24, 20:29

    FormEditorController.php:433

    fillFromConfigurationArray() set the "format" as well, should not matter here, but I still wanted to have talked about it.
  14. Stefan Bürk commented on patch set 4 09/04/24, 20:56

    FormEditorController.php:433 Reply

    Format is not documented for ext:form formEditorFluidConfiguration: https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Config/proto/formEditor/Index.html#prototypes.prototypeIdentifier.formeditor.formeditorfluidconfiguration So it may be breaking for people using it, but I postulate that this was never intendet here and thus working by "accident". What do you think ?
  15. Markus Klein commented on patch set 4 V +1 09/05/24, 06:59

    FormEditorController.php:433 Reply

    Full Ack!
  16. Simon Praetorius commented on patch set 4 09/05/24, 07:00

    FormEditorController.php:433 Reply

    Yes, you're right, it would be possible to set this. One more reason why we need to get rid of these magic configuration methods... I tend to agree with Stefan that we shouldn't support this anymore since it's not documented. It's also not part of the default FormSetup.yaml, which would be the place where I would look for possible options.
  17. Simon Praetorius commented on patch set 4 CR +2 V +2 09/05/24, 07:09

    FormEditorController.php:433 Reply

    Acknowledged
  18. Simon Praetorius merged patch set 5 09/05/24, 07:09