85863[BUGFIX] Allow BE user compare with outdated page content types
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +2
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +2
- core-ci +1 CI
Issues 2
Files 2
Review log 3646
Show 1521 earlier messages
-
Mathias Brodala uploaded patch set 1 09/04/24, 07:28
-
core-ci voted on patch set 1 V +1 09/04/24, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64722
-
Josef Glatz voted on patch set 1 CR +1 09/09/24, 09:10
-
Jasmina Ließmann uploaded patch set 2
CR +1V +109/09/24, 17:11 -
Jasmina Ließmann uploaded patch set 3 09/09/24, 17:13
-
core-ci voted on patch set 2 V +1 09/09/24, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65121
-
core-ci voted on patch set 3 V +1 09/09/24, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65122
-
Mathias Brodala commented on patch set 3 CR -1 09/10/24, 06:46
-
Mathias Brodala uploaded patch set 4
CR -1V +109/10/24, 06:47 -
Mathias Brodala uploaded patch set 5 09/10/24, 06:48
-
core-ci voted on patch set 4 V +1 09/10/24, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65179
-
core-ci voted on patch set 5 V +1 09/10/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65180
-
Jasmina Ließmann commented on patch set 5 09/10/24, 09:00
UserInformationService.php:242ReplyMy thought was that the key is difficult to recognize if it is always preceded by 'tt_content:CType:'. Especially if you have 15+ content elements. However, I forgot 'list_type'. Leave the patch as it is now. -
Jasmina Ließmann voted on patch set 5 CR +1 V +1 09/10/24, 09:20
-
Guido Schmechel voted on patch set 5 CR +1 10/03/24, 10:56
-
Oliver Hader updated the commit message in patch set 6
CR +1V +110/18/24, 14:01 -
Garvin Hicking rebased onto patch set 7 10/30/24, 16:05
The following files contain Git conflicts: * typo3/sysext/beuser/Classes/Service/UserInformationService.php * typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html -
Garvin Hicking commented on patch set 7 10/30/24, 16:08
I think this got addressed, need to check. -
core-ci voted on patch set 7 V -1 10/30/24, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68856
-
Josef Glatz wrote 10/31/24, 04:22
Removed reviewer Josef Glatz. -
Garvin Hicking commented on patch set 7 10/31/24, 08:32
Parts of this got addressed in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86563
-
Mathias Brodala commented on patch set 7 10/31/24, 08:42
UserInformationService.php:241Uh, Rebase gone bad? -
Mathias Brodala uploaded patch set 8
V -110/31/24, 08:45 -
Mathias Brodala commented on patch set 8 10/31/24, 08:45
This change is ready for review.UserInformationService.php:241ReplyRefreshed from scratch now. -
core-ci voted on patch set 8 V +1 10/31/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68896
-
Garvin Hicking commented on patch set 8 CR -1 10/31/24, 09:56
On it to create cherry-picks and verify behavior for 12/13/14 -
Jasmina Ließmann wrote 10/31/24, 09:57
Removed reviewer Jasmina Ließmann. -
Garvin Hicking uploaded patch set 9
CR -1V +110/31/24, 10:54 -
core-ci voted on patch set 9 V +1 10/31/24, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68905
-
Garvin Hicking updated the commit message in patch set 10
V +110/31/24, 11:10 -
core-ci voted on patch set 10 V +1 10/31/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68907
-
Garvin Hicking commented on patch set 10 CR +1 V +1 10/31/24, 11:28
Ok to recap, here's what I did: Example: - a `be_groups.explicit_allowdeny` value set to `tt_content:list_type:legacyElement`. - No label would be available (PHP exception without this patch) - The shortcode would be `legacyElement` - The longcode would be `tt_content:list_type:legacyElement` * main: - Continue to use short debug code (as introduced with #105282) - If a page content type does not exist, show a "N/A [longcode]" - If it exists, show "$label [shortcode]" - The shortcode label will also reveal the longcode as a title to aid in debugging * 13.4: - Same as in "main" * 12.4: - Since #105282 is not backported to 12.4, the "debug" showUid switch is not available. To still reveal needed extra information in case a page content type is missing, this will always be shown as "N/A [longcode]". - That means, for proper existing page content types, its short/longcode will not be displayed here -
Garvin Hicking commented on patch set 10 10/31/24, 11:28
Reply
Done -
Mathias Brodala commented on patch set 10 CR +1 V +1 10/31/24, 11:52
Verified on v12 -
Guido Schmechel voted on patch set 10 CR +1 11/02/24, 10:53
-
Guido Schmechel commented on patch set 10 V +1 11/02/24, 11:59
Tested with current main -
Sebastian Iffland voted on patch set 10 CR +1 11/04/24, 06:55
-
Benni Mack voted on patch set 10 CR +1 11/04/24, 06:57
-
Markus Klein voted on patch set 10 CR +1 11/05/24, 07:46
-
Simon Schaufelberger commented on patch set 10 11/05/24, 08:14
Information.html:468there is no reason to use the inline notation hereInformation.html:469whitespace before code can be removedInformation.html:472there is no reason to use the inline notation hereInformation.html:473whitespace before code can be removed -
Oli Bartsch voted on patch set 10 CR +2 V +2 11/05/24, 09:08
-
Oli Bartsch uploaded patch set 11
CR +1V +111/05/24, 09:10 -
Oli Bartsch commented on patch set 11 CR +2 V +2 11/05/24, 09:12
Information.html:468ReplyRight, but also no reason to change this as it's already used that way at other places.Information.html:469ReplyDoneInformation.html:472ReplyRight, but also no reason to change this as it's already used that way at other places.Information.html:473ReplyDone -
core-ci voted on patch set 11 V +1 11/05/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69087
-
Garvin Hicking voted on patch set 11 CR +2 V +2 11/05/24, 09:18
-
Garvin Hicking merged patch set 12 11/05/24, 09:18
UserInformationService.php:242