Review main Merged

85863[BUGFIX] Allow BE user compare with outdated page content types

Mathias Brodala CR +2 V +2 Easy +19 −4 updated 11/05/24, 09:18

Commit message

If groups of a BE user refer to outdated/removed page content
types, an exception in translating an empty label is no longer
thrown.

Instead, the label is displayed as "N/A" and the debug fieldname
will be fully revealed.

Also, the shortened debug fieldname will now be available as
extra information.

A drive-by bugfix is applied to ignoring an improper
user language reference which can also occur on "outdated"
user/group information, which can happen during updates and should
not lead to PHP exceptions at this point.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 3646

Show 1521 earlier messages
  1. Mathias Brodala uploaded patch set 1 09/04/24, 07:28

  2. core-ci voted on patch set 1 V +1 09/04/24, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64722

  3. Josef Glatz voted on patch set 1 CR +1 09/09/24, 09:10

  4. Jasmina Ließmann uploaded patch set 2 CR +1 V +1 09/09/24, 17:11

  5. Jasmina Ließmann uploaded patch set 3 09/09/24, 17:13

  6. core-ci voted on patch set 2 V +1 09/09/24, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65121

  7. core-ci voted on patch set 3 V +1 09/09/24, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65122

  8. Mathias Brodala commented on patch set 3 CR -1 09/10/24, 06:46

    UserInformationService.php:242

    @minapokhalo+typo3@gmail.com Why this change? The original version was intentionally written to ensure the original raw item value is rendered. Especially it is now not possible to distinguish "CType" from "list_type" items. I'll revert to the original version again.
  9. Mathias Brodala uploaded patch set 4 CR -1 V +1 09/10/24, 06:47

  10. Mathias Brodala uploaded patch set 5 09/10/24, 06:48

  11. core-ci voted on patch set 4 V +1 09/10/24, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65179

  12. core-ci voted on patch set 5 V +1 09/10/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65180

  13. Jasmina Ließmann commented on patch set 5 09/10/24, 09:00

    UserInformationService.php:242 Reply

    My thought was that the key is difficult to recognize if it is always preceded by 'tt_content:CType:'. Especially if you have 15+ content elements. However, I forgot 'list_type'. Leave the patch as it is now.
  14. Jasmina Ließmann voted on patch set 5 CR +1 V +1 09/10/24, 09:20

  15. Guido Schmechel voted on patch set 5 CR +1 10/03/24, 10:56

  16. Oliver Hader updated the commit message in patch set 6 CR +1 V +1 10/18/24, 14:01

  17. Garvin Hicking rebased onto patch set 7 10/30/24, 16:05

    The following files contain Git conflicts: * typo3/sysext/beuser/Classes/Service/UserInformationService.php * typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html
  18. Garvin Hicking commented on patch set 7 10/30/24, 16:08

    I think this got addressed, need to check.
  19. core-ci voted on patch set 7 V -1 10/30/24, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68856

  20. Josef Glatz wrote 10/31/24, 04:22

    Removed reviewer Josef Glatz.
  21. Garvin Hicking commented on patch set 7 10/31/24, 08:32

  1. Mathias Brodala commented on patch set 7 10/31/24, 08:42

    UserInformationService.php:241

    Uh, Rebase gone bad?
  2. Mathias Brodala uploaded patch set 8 V -1 10/31/24, 08:45

  3. Mathias Brodala commented on patch set 8 10/31/24, 08:45

    This change is ready for review.

    UserInformationService.php:241 Reply

    Refreshed from scratch now.
  4. core-ci voted on patch set 8 V +1 10/31/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68896

  5. Garvin Hicking commented on patch set 8 CR -1 10/31/24, 09:56

    On it to create cherry-picks and verify behavior for 12/13/14
  6. Jasmina Ließmann wrote 10/31/24, 09:57

    Removed reviewer Jasmina Ließmann.
  7. Garvin Hicking uploaded patch set 9 CR -1 V +1 10/31/24, 10:54

  8. core-ci voted on patch set 9 V +1 10/31/24, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68905

  9. Garvin Hicking updated the commit message in patch set 10 V +1 10/31/24, 11:10

  10. core-ci voted on patch set 10 V +1 10/31/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68907

  11. Garvin Hicking commented on patch set 10 CR +1 V +1 10/31/24, 11:28

    Ok to recap, here's what I did: Example: - a `be_groups.explicit_allowdeny` value set to `tt_content:list_type:legacyElement`. - No label would be available (PHP exception without this patch) - The shortcode would be `legacyElement` - The longcode would be `tt_content:list_type:legacyElement` * main: - Continue to use short debug code (as introduced with #105282) - If a page content type does not exist, show a "N/A [longcode]" - If it exists, show "$label [shortcode]" - The shortcode label will also reveal the longcode as a title to aid in debugging * 13.4: - Same as in "main" * 12.4: - Since #105282 is not backported to 12.4, the "debug" showUid switch is not available. To still reveal needed extra information in case a page content type is missing, this will always be shown as "N/A [longcode]". - That means, for proper existing page content types, its short/longcode will not be displayed here
  12. Garvin Hicking commented on patch set 10 10/31/24, 11:28

    Reply

    Done
  13. Mathias Brodala commented on patch set 10 CR +1 V +1 10/31/24, 11:52

    Verified on v12
  14. Guido Schmechel voted on patch set 10 CR +1 11/02/24, 10:53

  15. Guido Schmechel commented on patch set 10 V +1 11/02/24, 11:59

    Tested with current main
  16. Sebastian Iffland voted on patch set 10 CR +1 11/04/24, 06:55

  17. Benni Mack voted on patch set 10 CR +1 11/04/24, 06:57

  18. Markus Klein voted on patch set 10 CR +1 11/05/24, 07:46

  19. Simon Schaufelberger commented on patch set 10 11/05/24, 08:14

    Information.html:468

    there is no reason to use the inline notation here

    Information.html:469

    whitespace before code can be removed

    Information.html:472

    there is no reason to use the inline notation here

    Information.html:473

    whitespace before code can be removed
  20. Oli Bartsch voted on patch set 10 CR +2 V +2 11/05/24, 09:08

  21. Oli Bartsch uploaded patch set 11 CR +1 V +1 11/05/24, 09:10

  22. Oli Bartsch commented on patch set 11 CR +2 V +2 11/05/24, 09:12

    Information.html:468 Reply

    Right, but also no reason to change this as it's already used that way at other places.

    Information.html:469 Reply

    Done

    Information.html:472 Reply

    Right, but also no reason to change this as it's already used that way at other places.

    Information.html:473 Reply

    Done
  23. core-ci voted on patch set 11 V +1 11/05/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69087

  24. Garvin Hicking voted on patch set 11 CR +2 V +2 11/05/24, 09:18

  25. Garvin Hicking merged patch set 12 11/05/24, 09:18