Review main Merged

85865[TASK] Raise `phpstan/phpstan:^1.12.1`

Stefan Bürk CR +2 V +2 Easy +8 −8 updated 09/04/24, 09:21

Commit message

This change raises the phpstan package to ensure a
stable check across version which is required due
to changed detection behavior (bugfixes).

Used command(s):

> composer require --dev "phpstan/phpstan":"^1.12.1"
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Simon Praetorius +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Simon Praetorius +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Stefan Bürk uploaded patch set 1 09/04/24, 09:04

  2. core-ci voted on patch set 1 V +1 09/04/24, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64728

  3. Benni Mack voted on patch set 1 CR +1 V +1 09/04/24, 09:13

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 09/04/24, 09:20

  5. Simon Praetorius voted on patch set 1 CR +1 V +1 09/04/24, 09:21

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 09/04/24, 09:21

  7. Stefan Bürk merged patch set 2 09/04/24, 09:21