Review 12.4 Merged

85866[BUGFIX] Create same configuration in web and cli install process

Benjamin Franzke CR +2 V +2 Normal +115 −124 updated 09/09/24, 13:02

Commit message

The code for the web installer and the cli installer
is only partly aligned and shared, thus may easily
diverge, leading to different installation results.

The code to create system settings is now put
into SetupService and is used for both installation
methods, so that the cli install now also uses
FactoryConfiguration.php.

Additionally, the following cleanups are performed
to prepare further cleanup of the installation process:

* The cli setup does not set insecure trustedHostPattern any more.
* Silent config and template file changes are removed from setup,
  as conceptually these do nothing on newly created config and
  template files.
* New exceptions are created for config file generation instead
  of misusing a FAL-related exception.
* Absolute paths are made relative to project path before being
  passed to exception.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Benjamin Franzke uploaded patch set 1 09/04/24, 09:06

  2. core-ci voted on patch set 1 V +1 09/04/24, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64729

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/09/24, 13:02

  4. Benjamin Franzke merged patch set 2 09/09/24, 13:02