85869[TASK] Allow translation of site sets and settings labels
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 14
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+11 −0
- typo3/sysext/core/Classes/Site/TcaSiteSetCollector.php+7 −1
- typo3/sysext/felogin/Configuration/Sets/Felogin/config.yaml+1 −1
- typo3/sysext/felogin/Configuration/Sets/Felogin/settings.definitions.yaml+0 −50
- typo3/sysext/felogin/Resources/Private/Language/locallang_set.xlfnew+161 −0
- typo3/sysext/fluid_styled_content/Configuration/Sets/FluidStyledContent/config.yaml+1 −1
- typo3/sysext/fluid_styled_content/Configuration/Sets/FluidStyledContent/settings.definitions.yaml+0 −48
- typo3/sysext/fluid_styled_content/Resources/Private/Language/locallang_set.xlf1new+137 −0
- typo3/sysext/indexed_search/Configuration/Sets/IndexedSearch/config.yaml+1 −1
- typo3/sysext/indexed_search/Configuration/Sets/IndexedSearch/settings.definitions.yaml+0 −10
- typo3/sysext/indexed_search/Resources/Private/Language/locallang_set.xlfnew+27 −0
- typo3/sysext/seo/Configuration/Sets/Sitemap/config.yaml+1 −1
- typo3/sysext/seo/Configuration/Sets/Sitemap/settings.definitions.yaml+0 −12
- typo3/sysext/seo/Resources/Private/Language/locallang_sitemap_set.xlfnew+34 −0
Review log 1417
-
Benjamin Franzke uploaded patch set 1 09/04/24, 12:54
-
core-ci voted on patch set 1 V +1 09/04/24, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64755
-
Benjamin Franzke uploaded patch set 2
V +109/05/24, 10:10 -
Benjamin Franzke commented on patch set 2 09/05/24, 10:11
-
core-ci voted on patch set 2 V +1 09/05/24, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64852
-
Garvin Hicking updated the commit message in patch set 3
V +109/05/24, 12:05 -
Garvin Hicking commented on patch set 3 CR +1 09/05/24, 12:05
The docs patch in https://github.com/TYPO3-Documentation/render-guides/pull/734 has been merged, a release has been made. This should allow to continue rendering the docs without interruption when this patch gets merged. Many thanks for this foresight and integration! -
core-ci voted on patch set 3 V +1 09/05/24, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64862
-
Benni Mack commented on patch set 3 09/05/24, 12:36
I have a small (personal) wish. How about we just call the file "set.xlf" instead of "locallang_set.xlf" - I don't understand the locallang_ prefix anymore these days. -
Garvin Hicking commented on patch set 3 09/05/24, 12:52
Reply
personally I feel its a convention that's well established and people I'm in contact with usually refer to "locallang files" and less often to "xlf" files. It would create a fragmentation/confusion if not everythi g is changed to generally drop locallang everywhere. $0.0.2: if its not locallang here, it should be generally removed, leading to quite an impact though. On the upside: the "label" is configurable for the filename, so everyone would be free to use whatever filename in their exts/sitepackages...? -
Benni Mack commented on patch set 3 CR +1 V +1 09/05/24, 15:08
Reply
OK. -
Benjamin Franzke commented on patch set 3 CR +2 V +2 09/06/24, 07:03
Reply
I actually like the idea to drop `locallang` and would have even liked if the file would be located in `typo3/sysext/felogin/Configuration/Sets/*/labels.xlf`. Will probably do that in a separate change (as it requires another doc-renderer change), and I need to check the crowdin implications. -
Benjamin Franzke merged patch set 4 09/06/24, 07:06
-
Christian Kuhn commented on patch set 4 09/09/24, 14:55
More automagic key resolving :( I understand you're aiming for less .yaml mess, but this change has the structural drawback that it makes it harder to find unused labels. It is the opposite of what we postulated in fluid and other places already: aim for "full" specification using the entire lll:ext:path/to.xlf:my.label reference. Note we *probably* still have hundreds of unused labels and any magic added makes it harder to ever find these and adds efforts needed to streamline the label mess. I also think it is unfortunate to automagically add the "LLL:" prefix buried in the code somewhere. -
Benjamin Franzke commented on patch set 4 09/09/24, 15:15
Reply
Hi lolli, I understand your feedback in general and was sceptical do to this, but settings are aimed to be *easy* to write and I found and argument why it's fine to do this automagic here: We got a static list of setting definition keys, that means we can statically analyse and find left-over keys. (I'm happy to implement that) I'm very certain that this'll be a major DX improvement: * we can statically analyse the files * developers do not have to type the same identifiers over and over again (I'm really not enjoying "full" specification in self-contained environments (like sets) * This is the best compromise i could find for .xlf which are a main DX painpoint in general (compared to e.g. to c-style `gettext()` or similar thigs in lit-localize). BTW, content blocks plans for the same, and that's a good thing IMO. It would be awesome if we had virtual .xlf providers – but we unfortunately do not have that and still need to write .xlf ourselves… > I also think it is unfortunate to automagically add the "LLL:" prefix buried in the code somewhere. The `LLL:` prefix is an implementation detail in this case, I'm very open to better alternatives (I'm actually not aware we have them currently – excuse my ignorance – do we?). -
Christian Kuhn commented on patch set 4 09/09/24, 15:25
Reply
I see. Taming the label mess is obviously a bigger task and challenge, and I wanted to make sure we're not adding stuff that makes this harder to get right. It's good this can be analyzed statically, and I hope we'll see more steps regarding label management in v14. Let's just not loose this topic from our radar, thanks for keeping this area in the back of your head. -
Benjamin Franzke commented on patch set 4 09/09/24, 19:11
Reply
85931: [TASK] Add integrity check for set and setting labels | https://review.typo3.org/c/Packages/TYPO3.CMS/+/85931
locallang_set.xlf:9