Review main Merged

85870[TASK] Improve a11y of disabled recycler search-submit-button

Ayke Halder CR +2 V +2 Easy +6 −6 updated 09/10/24, 10:28

Commit message

This changes the `disabled`-attribute of the
recycler's search-submit-button. Thereby screen-
readers can announce that the button is disabled.

Before this there was toggling implemented for
`class="disabled"`. Thereby the 'disabled' button
was still active and could be activated by
keyboard.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Benjamin Kott +1

Issues 1

Files 3

Review log 68

  1. Ayke Halder uploaded patch set 1 09/04/24, 13:44

  2. core-ci voted on patch set 1 V +1 09/04/24, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64760

  3. Lina Wolf commented on patch set 1 CR +1 V +1 09/06/24, 14:26

    Code looks good and works for my machine
  4. Benjamin Kott uploaded patch set 2 CR +1 V +1 09/10/24, 10:15

  5. Benjamin Kott voted on patch set 2 CR +1 V +1 09/10/24, 10:24

  6. Andreas Nedbal voted on patch set 2 CR +2 V +2 09/10/24, 10:26

  7. Andreas Nedbal merged patch set 3 09/10/24, 10:27

  8. core-ci voted on patch set 2 V +1 09/10/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65212