Review main Merged

85871[TASK] Improve a11y of disabled record-action-buttons in workspace-review

Ayke Halder CR +2 V +2 Normal +29 −42 updated 09/10/24, 13:05

Commit message

This changes disabled record-action-buttons in workspace-review to use
a `button`-tag with `disabled`-attribute. Thereby screenreaders can
announce that a button is disabled.

Before this a disabled record-action-button was rendered as
`span`-tag with `class="disabled"`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Ayke Halder uploaded patch set 1 09/04/24, 15:15

  2. core-ci voted on patch set 1 V +1 09/04/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64773

  3. Benjamin Kott voted on patch set 1 CR +1 V +1 09/10/24, 13:01

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 09/10/24, 13:05

  5. Andreas Kienast merged patch set 2 09/10/24, 13:05