Review main Merged

85894[BUGFIX] Provide fallback ViewFactory for InstallTool context

Simon Praetorius CR +2 V +2 Easy +19 −0 updated 09/23/24, 08:55

Commit message

The InstallTool login-notification runs in failsafe mode,
that means the symfony DI container is not booted (only
FailsafeContainer is running to avoid stale caches to
prevent interaction with the install tool).

Provide an optional fallback implementation of the
ViewFactory interface for this context, but let it be
configurable for userspace.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Simon Praetorius uploaded patch set 1 09/04/24, 19:00

  2. Simon Praetorius marked it work in progress 09/04/24, 19:01

  3. core-ci voted on patch set 1 V +1 09/04/24, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64808

  4. Benjamin Franzke uploaded patch set 2 V +1 09/23/24, 08:10

  5. Benjamin Franzke commented on patch set 2 09/23/24, 08:10

    ServiceProvider.php:51

    I don't really understand why the `FluidViewFactory` – that depends on EXT:fluid's `RenderingContextFactory` – was placed into `EXT:core` at all. I've moved the service provider definition to `EXT:fluid` now, where IMO `FluidViewFactory` should be moved to as well.

    ServiceProvider.php:115

    I migrated this into an extension (as also done for the event dispatcher in EXT:core), so it can still be configured via Services.yaml for userspace.
  6. core-ci voted on patch set 2 V +1 09/23/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66421

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 09/23/24, 08:55

  8. Andreas Kienast merged patch set 3 09/23/24, 08:55