85899[FEATURE] Add widgets for EXT:sys_note
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Frank Nägler +1
-
Verified V +2 Done
- Benni Mack +2
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 12
- Build/Sources/Sass/dashboard/_widget.scss+20 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst4new+25 −0
- typo3/sysext/core/Tests/Acceptance/Application/Dashboard/DashboardModuleCest.php+1 −0
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+5 −0
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php2+67 −0
- typo3/sysext/sys_note/Classes/Widgets/PagesWithInternalNote.phpnew+74 −0
- typo3/sysext/sys_note/Configuration/Backend/DashboardPresets.phpnew+11 −0
- typo3/sysext/sys_note/Configuration/Backend/DashboardWidgetGroups.phpnew+7 −0
- typo3/sysext/sys_note/Configuration/Services.yaml+96 −0
- typo3/sysext/sys_note/Resources/Private/Language/locallang.xlf2+57 −0
- typo3/sysext/sys_note/Resources/Private/Templates/Widget/PagesWithInternalNote.html12new+46 −0
- typo3/sysext/sys_note/Resources/Private/Templates/List.html+16 −16
Review log 4965
Show 3040 earlier messages
-
Philipp Kuhlmay uploaded patch set 1 09/05/24, 11:18
-
Philipp Kuhlmay wrote 09/05/24, 11:18
Set private -
Philipp Kuhlmay uploaded patch set 2 09/05/24, 11:32
-
Philipp Kuhlmay uploaded patch set 3 09/05/24, 11:33
-
Philipp Kuhlmay uploaded patch set 4 09/05/24, 13:14
-
Philipp Kuhlmay marked it work in progress 09/06/24, 09:15
-
Philipp Kuhlmay wrote 09/06/24, 09:15
Unset private -
Philipp Kuhlmay uploaded patch set 5 09/06/24, 10:02
-
Philipp Kuhlmay marked it ready for review 09/06/24, 10:03
-
Philipp Kuhlmay marked it work in progress 09/06/24, 10:04
-
Philipp Kuhlmay updated the commit message in patch set 6 09/06/24, 10:10
-
core-ci voted on patch set 5 V -1 09/06/24, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64929
-
core-ci voted on patch set 6 V -1 09/06/24, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64931
-
Philipp Kuhlmay uploaded patch set 7
V -109/06/24, 10:23 -
core-ci voted on patch set 7 V -1 09/06/24, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64932
-
Philipp Kuhlmay uploaded patch set 8
V -109/06/24, 10:37 -
Philipp Kuhlmay marked it ready for review 09/06/24, 10:39
-
core-ci voted on patch set 8 V -1 09/06/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64936
-
Philipp Kuhlmay uploaded patch set 9
V -109/06/24, 10:46 -
Georg Ringer commented on patch set 8 09/06/24, 10:46
also pls remove the .gitkeep filePageOverviewWidget.php:1doc header is missing at all filesPageProviderInterface.php:10return int[]PagesWithInternalNoteToDosDataProvider.php:1why not using the repository of sys_note?widgets.css:1we should build that file with the pipeline I suggest -
core-ci voted on patch set 9 V -1 09/06/24, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64938
-
Philipp Kuhlmay uploaded patch set 10
V -109/06/24, 10:56 -
Philipp Kuhlmay commented on patch set 10 09/06/24, 11:00
Reply
Done.PageOverviewWidget.php:1ReplyCI mentioned it and I already included it.PageProviderInterface.php:10ReplyI changed it. Is it correct to only set it inside the php doc header?PagesWithInternalNoteToDosDataProvider.php:1ReplyActually, I don't know how to use the repository of sys_note. I used the code which worked for me in v12 and adapted it to include it into the core. If you know how, please let me know. -
core-ci voted on patch set 10 V -1 09/06/24, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64941
-
Chris Müller commented on patch set 10 09/06/24, 12:11
Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst:14Maybe use "internal notes" instead of sys_notes as this is the name in the backend. maybe also "internal notes (EXT:sys_note)" or something similar.Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst:15maybe: "... for each internal note type"? And another suggestion: list those widgets. -
Chris Müller commented on patch set 10 09/06/24, 12:22
locallang.xlf:43In all new translations "resname" is missing, and xml:space is not necessary and should be removed.ExtendedListWidget.html:2core is not used here and can be removed.PagesWithInternalNote.html:3be is not used here and can be removed. -
Philipp Kuhlmay uploaded patch set 11
V -109/06/24, 13:04 -
core-ci voted on patch set 11 V -1 09/06/24, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64954
-
Philipp Kuhlmay uploaded patch set 12
V -109/06/24, 13:11 -
Philipp Kuhlmay uploaded patch set 13 09/06/24, 13:13
-
Philipp Kuhlmay commented on patch set 13 09/06/24, 13:14
PagesWithInternalNoteToDosDataProvider.php:1ReplyI now use the SysNoteRepository. I had to add a new method. I also removed the now unnecessary providers which I created before.locallang.xlf:43ReplyFixed it.ExtendedListWidget.html:2ReplyFixed it.PagesWithInternalNote.html:3ReplyFixed it -
core-ci voted on patch set 12 V -1 09/06/24, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64955
-
core-ci voted on patch set 13 V -1 09/06/24, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64957
-
Philipp Kuhlmay uploaded patch set 14
V -109/06/24, 13:46 -
Philipp Kuhlmay commented on patch set 14 09/06/24, 13:47
Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst:14ReplyI changed it accordingly.Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst:15ReplyI changed it accordingly. -
core-ci voted on patch set 14 V -1 09/06/24, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64960
-
Frank Nägler commented on patch set 14 CR -1 09/10/24, 08:01
PageOverviewWidget.php:1Can you explain the name of this class? I think the the naming is missleading. I would like to see a name like SysNoteWidget.PageOverviewWidget.php:50Not sure about the restriction to the current backend user. As admin / integrator I maybe also create sys_notes with instructions for the editors. this nodes will not be visible in the dashboard. IIRC we don't need the restriction to the author here.Services.php:1Is there a reason for a Services.php? Can we use Service.yaml here?Widget.html:6No headline element should be an h2 element with class h3, like in the origin layout. I would also use the core layout and move the color and icon into the content. E.g. use color classes in the table header. So you don't need to overwrite the layout class,ExtendedListWidget.html:1Where is this template used?PageOverviewWidget.html:1Where is this templates used? -
Frank Nägler commented on patch set 14 09/10/24, 08:18
PagesWithInternalNote.html:7<thead> and <tbody> missing -
Frank Nägler commented on patch set 14 09/10/24, 08:19
PagesWithInternalNote.html:10colspan="2" and remove following thPagesWithInternalNote.html:22text-end instead of text-right -
Frank Nägler commented on patch set 14 09/10/24, 09:30
on itPageOverviewWidget.php:1ReplyDoneServices.php:1ReplyDoneWidget.html:6ReplyDoneExtendedListWidget.html:1ReplyDonePageOverviewWidget.html:1ReplyDonePagesWithInternalNote.html:7ReplyDonePagesWithInternalNote.html:10ReplyDonePagesWithInternalNote.html:22ReplyDone
-
Garvin Hicking commented on patch set 14 09/10/24, 11:44
PageOverviewWidget.php:50ReplyIMO this is an important point. I would expect to see all notes that are - not personal (sys_note.personal=0) - OR were created by to me (no matter if personal or not). I would not expect to see personal notes of other editors/admins. -
Frank Nägler uploaded patch set 15
CR -1V -109/10/24, 11:45 -
Garvin Hicking commented on patch set 15 09/10/24, 11:52
PagesWithInternalNote.html:19missing localizationPagesWithInternalNote.html:27missing localization -
core-ci voted on patch set 15 V -1 09/10/24, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65222
-
Frank Nägler uploaded patch set 16
V -109/10/24, 12:48 -
Frank Nägler commented on patch set 16 09/10/24, 12:49
PagesWithInternalNote.html:19ReplyAcknowledgedPagesWithInternalNote.html:27ReplyAcknowledged -
core-ci voted on patch set 16 V -1 09/10/24, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65242
-
Frank Nägler uploaded patch set 17
V -109/10/24, 13:44 -
core-ci voted on patch set 17 V -1 09/10/24, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65255
-
Frank Nägler uploaded patch set 18
V -109/10/24, 14:24 -
core-ci voted on patch set 18 V +1 09/10/24, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65261
-
Frank Nägler voted on patch set 18 CR +1 V +1 09/10/24, 16:34
-
Garvin Hicking commented on patch set 18 09/10/24, 16:48
PageOverviewWidget.php:50Reply(Also I believe currently "hidden" sys_note records would also be displayed) -
Frank Nägler commented on patch set 18 09/10/24, 16:52
PageOverviewWidget.php:50ReplyI don't believe, I know, and what I know is, that sys_note records can not be hidden ;) -
Garvin Hicking commented on patch set 18 09/10/24, 17:22
PageOverviewWidget.php:50ReplyHehe, you got me there, good to know now how ☺️ What's your thought on the "personal" attribute? -
Frank Nägler commented on patch set 18 CR -1 09/10/24, 17:27
PageOverviewWidget.php:50Replyah, not seen, will take care. Valid point -
Frank Nägler uploaded patch set 19
CR -1V +109/10/24, 17:51 -
Frank Nägler commented on patch set 19 09/10/24, 17:57
PageOverviewWidget.php:50ReplyAcknowledgedPageProviderInterface.php:10ReplyDonewidgets.css:1ReplyDone -
Frank Nägler voted on patch set 19 CR +1 V +1 09/10/24, 17:57
-
core-ci voted on patch set 19 V -1 09/10/24, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65303
-
core-ci voted on patch set 19 V +1 09/10/24, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65303
-
Benni Mack voted on patch set 19 CR +2 V +2 09/10/24, 19:16
-
Benni Mack merged patch set 20 09/10/24, 19:16
-
Stefan Bürk commented on patch set 20 09/10/24, 19:33
SysNoteRepository.php:116**POST -1** If we loop the result directly, we use the while-construct ... ``` $result = $queryBuilder->executeQuery(); while ($row = $result->fetchAssociative() { ... } ``` approch, special if not the full result set is directly used (due to the conditon check). -
Benni Mack commented on patch set 20 09/10/24, 20:00
SysNoteRepository.php:116Replychanged in followup