Review main Merged

85899[FEATURE] Add widgets for EXT:sys_note

Philipp Kuhlmay CR +2 V +2 Hard +425 −16 updated 09/10/24, 20:00

Commit message

This adds some widgets for EXT:dashboard, which shows a list of the corresponding sys_notes inside the TYPO3 system.

The widgets are copied from EXT:treupo_sys_note_widgets which will not be developed further, as all the widgets are now inside the TYPO3 core.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 4965

Show 3040 earlier messages
  1. Philipp Kuhlmay uploaded patch set 1 09/05/24, 11:18

  2. Philipp Kuhlmay wrote 09/05/24, 11:18

    Set private
  3. Philipp Kuhlmay uploaded patch set 2 09/05/24, 11:32

  4. Philipp Kuhlmay uploaded patch set 3 09/05/24, 11:33

  5. Philipp Kuhlmay uploaded patch set 4 09/05/24, 13:14

  6. Philipp Kuhlmay marked it work in progress 09/06/24, 09:15

  7. Philipp Kuhlmay wrote 09/06/24, 09:15

    Unset private
  8. Philipp Kuhlmay uploaded patch set 5 09/06/24, 10:02

  9. Philipp Kuhlmay marked it ready for review 09/06/24, 10:03

  10. Philipp Kuhlmay marked it work in progress 09/06/24, 10:04

  11. Philipp Kuhlmay updated the commit message in patch set 6 09/06/24, 10:10

  12. core-ci voted on patch set 5 V -1 09/06/24, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64929

  13. core-ci voted on patch set 6 V -1 09/06/24, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64931

  14. Philipp Kuhlmay uploaded patch set 7 V -1 09/06/24, 10:23

  15. core-ci voted on patch set 7 V -1 09/06/24, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64932

  16. Philipp Kuhlmay uploaded patch set 8 V -1 09/06/24, 10:37

  17. Philipp Kuhlmay marked it ready for review 09/06/24, 10:39

  18. core-ci voted on patch set 8 V -1 09/06/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64936

  19. Philipp Kuhlmay uploaded patch set 9 V -1 09/06/24, 10:46

  20. Georg Ringer commented on patch set 8 09/06/24, 10:46

    also pls remove the .gitkeep file

    PageOverviewWidget.php:1

    doc header is missing at all files

    PageProviderInterface.php:10

    return int[]

    PagesWithInternalNoteToDosDataProvider.php:1

    why not using the repository of sys_note?

    widgets.css:1

    we should build that file with the pipeline I suggest
  21. core-ci voted on patch set 9 V -1 09/06/24, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64938

  22. Philipp Kuhlmay uploaded patch set 10 V -1 09/06/24, 10:56

  23. Philipp Kuhlmay commented on patch set 10 09/06/24, 11:00

    Reply

    Done.

    PageOverviewWidget.php:1 Reply

    CI mentioned it and I already included it.

    PageProviderInterface.php:10 Reply

    I changed it. Is it correct to only set it inside the php doc header?

    PagesWithInternalNoteToDosDataProvider.php:1 Reply

    Actually, I don't know how to use the repository of sys_note. I used the code which worked for me in v12 and adapted it to include it into the core. If you know how, please let me know.
  24. core-ci voted on patch set 10 V -1 09/06/24, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64941

  25. Chris Müller commented on patch set 10 09/06/24, 12:11

    Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst:14

    Maybe use "internal notes" instead of sys_notes as this is the name in the backend. maybe also "internal notes (EXT:sys_note)" or something similar.

    Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst:15

    maybe: "... for each internal note type"? And another suggestion: list those widgets.
  26. Chris Müller commented on patch set 10 09/06/24, 12:22

    locallang.xlf:43

    In all new translations "resname" is missing, and xml:space is not necessary and should be removed.

    ExtendedListWidget.html:2

    core is not used here and can be removed.

    PagesWithInternalNote.html:3

    be is not used here and can be removed.
  27. Philipp Kuhlmay uploaded patch set 11 V -1 09/06/24, 13:04

  28. core-ci voted on patch set 11 V -1 09/06/24, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64954

  29. Philipp Kuhlmay uploaded patch set 12 V -1 09/06/24, 13:11

  30. Philipp Kuhlmay uploaded patch set 13 09/06/24, 13:13

  31. Philipp Kuhlmay commented on patch set 13 09/06/24, 13:14

    PagesWithInternalNoteToDosDataProvider.php:1 Reply

    I now use the SysNoteRepository. I had to add a new method. I also removed the now unnecessary providers which I created before.

    locallang.xlf:43 Reply

    Fixed it.

    ExtendedListWidget.html:2 Reply

    Fixed it.

    PagesWithInternalNote.html:3 Reply

    Fixed it
  32. core-ci voted on patch set 12 V -1 09/06/24, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64955

  33. core-ci voted on patch set 13 V -1 09/06/24, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64957

  34. Philipp Kuhlmay uploaded patch set 14 V -1 09/06/24, 13:46

  35. Philipp Kuhlmay commented on patch set 14 09/06/24, 13:47

    Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst:14 Reply

    I changed it accordingly.

    Feature-104844-Dashboard-Sys_note-AddWidgetsForListingAllTheSys_notesInsideTheTYPO3System.rst:15 Reply

    I changed it accordingly.
  36. core-ci voted on patch set 14 V -1 09/06/24, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64960

  37. Frank Nägler commented on patch set 14 CR -1 09/10/24, 08:01

    PageOverviewWidget.php:1

    Can you explain the name of this class? I think the the naming is missleading. I would like to see a name like SysNoteWidget.

    PageOverviewWidget.php:50

    Not sure about the restriction to the current backend user. As admin / integrator I maybe also create sys_notes with instructions for the editors. this nodes will not be visible in the dashboard. IIRC we don't need the restriction to the author here.

    Services.php:1

    Is there a reason for a Services.php? Can we use Service.yaml here?

    Widget.html:6

    No headline element should be an h2 element with class h3, like in the origin layout. I would also use the core layout and move the color and icon into the content. E.g. use color classes in the table header. So you don't need to overwrite the layout class,

    ExtendedListWidget.html:1

    Where is this template used?

    PageOverviewWidget.html:1

    Where is this templates used?
  38. Frank Nägler commented on patch set 14 09/10/24, 08:18

    PagesWithInternalNote.html:7

    <thead> and <tbody> missing
  39. Frank Nägler commented on patch set 14 09/10/24, 08:19

    PagesWithInternalNote.html:10

    colspan="2" and remove following th

    PagesWithInternalNote.html:22

    text-end instead of text-right
  40. Frank Nägler commented on patch set 14 09/10/24, 09:30

    on it

    PageOverviewWidget.php:1 Reply

    Done

    Services.php:1 Reply

    Done

    Widget.html:6 Reply

    Done

    ExtendedListWidget.html:1 Reply

    Done

    PageOverviewWidget.html:1 Reply

    Done

    PagesWithInternalNote.html:7 Reply

    Done

    PagesWithInternalNote.html:10 Reply

    Done

    PagesWithInternalNote.html:22 Reply

    Done
  1. Garvin Hicking commented on patch set 14 09/10/24, 11:44

    PageOverviewWidget.php:50 Reply

    IMO this is an important point. I would expect to see all notes that are - not personal (sys_note.personal=0) - OR were created by to me (no matter if personal or not). I would not expect to see personal notes of other editors/admins.
  2. Frank Nägler uploaded patch set 15 CR -1 V -1 09/10/24, 11:45

  3. Garvin Hicking commented on patch set 15 09/10/24, 11:52

    PagesWithInternalNote.html:19

    missing localization

    PagesWithInternalNote.html:27

    missing localization
  4. core-ci voted on patch set 15 V -1 09/10/24, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65222

  5. Frank Nägler uploaded patch set 16 V -1 09/10/24, 12:48

  6. Frank Nägler commented on patch set 16 09/10/24, 12:49

    PagesWithInternalNote.html:19 Reply

    Acknowledged

    PagesWithInternalNote.html:27 Reply

    Acknowledged
  7. core-ci voted on patch set 16 V -1 09/10/24, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65242

  8. Frank Nägler uploaded patch set 17 V -1 09/10/24, 13:44

  9. core-ci voted on patch set 17 V -1 09/10/24, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65255

  10. Frank Nägler uploaded patch set 18 V -1 09/10/24, 14:24

  11. core-ci voted on patch set 18 V +1 09/10/24, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65261

  12. Frank Nägler voted on patch set 18 CR +1 V +1 09/10/24, 16:34

  13. Garvin Hicking commented on patch set 18 09/10/24, 16:48

    PageOverviewWidget.php:50 Reply

    (Also I believe currently "hidden" sys_note records would also be displayed)
  14. Frank Nägler commented on patch set 18 09/10/24, 16:52

    PageOverviewWidget.php:50 Reply

    I don't believe, I know, and what I know is, that sys_note records can not be hidden ;)
  15. Garvin Hicking commented on patch set 18 09/10/24, 17:22

    PageOverviewWidget.php:50 Reply

    Hehe, you got me there, good to know now how ☺️ What's your thought on the "personal" attribute?
  16. Frank Nägler commented on patch set 18 CR -1 09/10/24, 17:27

    PageOverviewWidget.php:50 Reply

    ah, not seen, will take care. Valid point
  17. Frank Nägler uploaded patch set 19 CR -1 V +1 09/10/24, 17:51

  18. Frank Nägler commented on patch set 19 09/10/24, 17:57

    PageOverviewWidget.php:50 Reply

    Acknowledged

    PageProviderInterface.php:10 Reply

    Done

    widgets.css:1 Reply

    Done
  19. Frank Nägler voted on patch set 19 CR +1 V +1 09/10/24, 17:57

  20. core-ci voted on patch set 19 V -1 09/10/24, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65303

  21. core-ci voted on patch set 19 V +1 09/10/24, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65303

  22. Benni Mack voted on patch set 19 CR +2 V +2 09/10/24, 19:16

  23. Benni Mack merged patch set 20 09/10/24, 19:16

  24. Stefan Bürk commented on patch set 20 09/10/24, 19:33

    SysNoteRepository.php:116

    **POST -1** If we loop the result directly, we use the while-construct ... ``` $result = $queryBuilder->executeQuery(); while ($row = $result->fetchAssociative() { ... } ``` approch, special if not the full result set is directly used (due to the conditon check).
  25. Benni Mack commented on patch set 20 09/10/24, 20:00

    SysNoteRepository.php:116 Reply

    changed in followup