85910[TASK] Enhance Regular Expression parsing for CKEditor YAML config
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 4
- Build/Sources/TypeScript/rte_ckeditor/ckeditor5.ts+7 −0
- typo3/sysext/core/Documentation/Changelog/12.4.x/Important-104827-AllowToUseRegularExpressionsInCKEditorYAML.rstnew+106 −0
- typo3/sysext/rte_ckeditor/Configuration/RTE/Default.yaml7+6 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/ckeditor5.js+1 −1
Review log 2836
Show 811 earlier messages
-
Garvin Hicking uploaded patch set 1 09/06/24, 09:04
-
core-ci voted on patch set 1 V +1 09/06/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64920
-
Chris Müller commented on patch set 1 09/06/24, 12:30
Feature-104827-AllowCkEditorRegularExpressionObject.rst:39beginning -> endFeature-104827-AllowCkEditorRegularExpressionObject.rst:42they -> the -
Garvin Hicking uploaded patch set 2
V +109/09/24, 06:36wording changes -
core-ci voted on patch set 2 V +1 09/09/24, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65058
-
Garvin Hicking commented on patch set 2 09/09/24, 06:45
Feature-104827-AllowCkEditorRegularExpressionObject.rst:26ReplyDoneFeature-104827-AllowCkEditorRegularExpressionObject.rst:39ReplyDoneFeature-104827-AllowCkEditorRegularExpressionObject.rst:42ReplyDone -
Chris Müller commented on patch set 2 09/09/24, 07:01
Please also add the feature to the docs of this sysext. -
Garvin Hicking commented on patch set 2 09/09/24, 08:56
Reply
I'll wait with this until it's clear whether this feature is something that is useful. -
Garvin Hicking commented on patch set 2 CR -1 09/10/24, 08:42
Going for another approach with Benjamin Franzke's feedback. -
Garvin Hicking uploaded patch set 3
CR -1V +109/10/24, 10:26Rework patch -
core-ci voted on patch set 3 V +1 09/10/24, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65214
-
Benjamin Franzke uploaded patch set 4
V +109/10/24, 18:18 -
core-ci voted on patch set 4 V +1 09/10/24, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65316
-
Thomas Hohn voted on patch set 4 CR +1 09/13/24, 07:58
-
Sebastian Iffland commented on patch set 4 CR +1 09/13/24, 08:02
Default.yaml:12Wouldn't it be better to use one pattern all over? In the RST file and commit message `(tsconf|t3ts)$` applies, here differing. Just been curious. -
Garvin Hicking commented on patch set 4 09/13/24, 08:19
Default.yaml:12ReplyI made it smaller for the changelog/commit msg to fit the rendered screen, which wasn't an issue for a larger yaml file. Since its just a dummy example, ideally I'd try to not reset votes for the change? 😇 -
Sebastian Iffland commented on patch set 4 09/13/24, 08:25
Default.yaml:12ReplyAcknowledged -
Guido Schmechel voted on patch set 4 CR +1 09/13/24, 10:57
-
Stefan Bürk voted on patch set 4 CR +1 V +1 09/13/24, 21:05
-
Garvin Hicking commented on patch set 4 CR -1 09/13/24, 21:09
Default.yaml:13Wrong link, needs correction (Important, not festure). And move to 12.4 dir. -
Stefan Bürk commented on patch set 5
CR +1V +109/13/24, 23:14Published edit on patch set 4. -
Stefan Bürk commented on patch set 6 09/13/24, 23:15
Published edit on patch set 5. -
Stefan Bürk commented on patch set 6 CR +1 V +1 09/13/24, 23:15
Default.yaml:13Replydone - also in backport. -
core-ci voted on patch set 5 V +1 09/13/24, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65717
-
core-ci voted on patch set 6 V +1 09/13/24, 23:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65719
-
Benjamin Franzke voted on patch set 6 CR +1 V +1 09/14/24, 03:17
-
Garvin Hicking commented on patch set 6 09/14/24, 07:08
Default.yaml:13ReplyI think this is missing "12.4" as directory, need to check -
Garvin Hicking uploaded patch set 7
CR +1V +109/14/24, 07:40Adjust link in YAML -
Garvin Hicking commented on patch set 7 CR +1 V +1 09/14/24, 07:43
Default.yaml:13ReplyDone -
core-ci voted on patch set 7 V -1 09/14/24, 07:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65742
-
Garvin Hicking rebased onto patch set 8
CR +1V +109/14/24, 10:02 -
Anja Leichsenring voted on patch set 8 CR +1 V +1 09/14/24, 10:06
-
core-ci voted on patch set 8 V +1 09/14/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65750
-
Benjamin Franzke voted on patch set 8 CR +1 V +1 09/14/24, 16:29
-
Garvin Hicking voted on patch set 8 CR +2 V +2 09/14/24, 17:41
-
Garvin Hicking merged patch set 9 09/14/24, 17:41
Feature-104827-AllowCkEditorRegularExpressionObject.rst:26