Review main Merged

85912[TASK] Add tests for moving language -1 content

Eric Harrer CR +2 V +2 Nightmare +2470 −547 updated 01/07/25, 14:02

Commit message

* Change DataScenarios/Regular by renaming tt_content CE
  uid 296 to 200
* Extend DataScenarios/Regular to have a sys_language_uid -1
  content element on page 88 as uid 201
* Add tests that move CE 201 to page 89 "into" and "after first"
  existing CE, verify FE output in "fallback", "free" and "strict"
  mode

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • André Buchmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 272

Show 252 more files

Review log 2231

Show 36 earlier messages
  1. Eric Harrer uploaded patch set 1 09/06/24, 09:30

  2. core-ci voted on patch set 1 V -1 09/06/24, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64924

  3. Eric Harrer uploaded patch set 2 V -1 10/04/24, 14:21

  4. Eric Harrer uploaded patch set 3 10/04/24, 14:24

  5. core-ci voted on patch set 2 V -1 10/04/24, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67099

  6. core-ci voted on patch set 3 V -1 10/04/24, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67100

  1. Eric Harrer uploaded patch set 4 V -1 10/04/24, 14:45

  2. core-ci voted on patch set 4 V +1 10/04/24, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67103

  3. Eric Harrer updated the commit message in patch set 5 V +1 10/25/24, 10:50

  4. core-ci voted on patch set 5 V +1 10/25/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68613

  5. Simon Schaufelberger updated the commit message in patch set 6 V +1 10/25/24, 12:00

  6. Simon Schaufelberger voted on patch set 6 CR +1 V +1 10/25/24, 12:02

  7. core-ci voted on patch set 6 V +1 10/25/24, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68619

  8. Astrid Haubold voted on patch set 6 CR +1 11/12/24, 12:11

  9. Astrid Haubold voted on patch set 6 V +1 11/12/24, 12:12

  10. André Buchmann voted on patch set 6 CR +1 V +1 12/20/24, 12:09

  11. Eric Harrer commented on patch set 6 12/20/24, 12:15

    @lolli@schwarzbu.ch All requirements are met. Please merge this patch.
  12. Christian Kuhn commented on patch set 6 CR -1 01/06/25, 14:25

    working on in.

    ActionTestLanguageAll.php:26

    these tests are not executed since the filename does not end with *Test.php. i would also prefer to merge the rather tiny change on the imported .csv into the main import.csv file to not have a second set of test and fixture files within the Regular/ directory.
  13. Christian Kuhn uploaded patch set 7 CR +1 V +1 01/06/25, 16:05

  14. Christian Kuhn uploaded patch set 8 01/06/25, 16:07

  15. Christian Kuhn commented on patch set 8 CR -1 01/06/25, 16:08

    missing workspace scenarios, will continue to work on this tomorrow.

    ActionTestLanguageAll.php:26 Reply

    Done
  16. core-ci voted on patch set 7 V +1 01/06/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71993

  17. core-ci voted on patch set 8 V +1 01/06/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71994

  18. Christian Kuhn uploaded patch set 9 CR -1 V +1 01/07/25, 12:15

  19. core-ci voted on patch set 9 V +1 01/07/25, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72041

  20. Christian Kuhn voted on patch set 9 CR +1 V +1 01/07/25, 12:26

  21. Stefan Bürk commented on patch set 9 CR -1 01/07/25, 13:23

    Reviewing ....
  22. Stefan Bürk voted on patch set 9 CR +1 V +1 01/07/25, 13:48

  23. André Buchmann voted on patch set 9 CR +1 01/07/25, 14:02

  24. Christian Kuhn voted on patch set 9 CR +2 V +2 01/07/25, 14:02

  25. Christian Kuhn merged patch set 10 01/07/25, 14:02