Review main Merged

85913[FEATURE] Enable custom field transformation

Oli Bartsch CR +2 V +2 Hard +300 −6 updated 12/11/24, 08:01

Commit message

The new PSR-14 RecordCreationEvent is introduced in
order to allow the manipulation of any property
before being used to create a Record object.

The event is even capable of creating the Record
object on its own.

Using the event, extension authors can apply custom
transformations for fields, e.g. creating custom
objects for field values. The properties to operate
on are either already transformed or the raw values,
in case no transformation matched the field type.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2233

Show 48 earlier messages
  1. Oli Bartsch uploaded patch set 1 09/06/24, 10:47

  2. core-ci voted on patch set 1 V -1 09/06/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64939

  3. Oli Bartsch uploaded patch set 2 V -1 09/06/24, 13:42

  4. core-ci voted on patch set 2 V +1 09/06/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64959

  5. Oli Bartsch uploaded patch set 3 V +1 09/06/24, 14:42

  6. Oli Bartsch uploaded patch set 4 09/06/24, 14:46

  7. core-ci voted on patch set 3 V -1 09/06/24, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64978

  8. core-ci voted on patch set 4 V -1 09/06/24, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64979

  1. core-ci voted on patch set 4 V +1 09/06/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64979

  2. Georg Ringer commented on patch set 5 V +1 09/06/24, 17:43

    Published edit on patch set 4.
  3. Georg Ringer voted on patch set 5 CR +1 V +1 09/06/24, 17:43

  4. core-ci voted on patch set 5 V +1 09/06/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64995

  5. Guido Schmechel voted on patch set 5 CR +1 V +1 09/07/24, 17:02

  6. Benni Mack commented on patch set 5 CR -2 09/09/24, 07:38

    I think we should rather work with RecordInterface... will work on that w/ Oli on that,
  7. Oli Bartsch uploaded patch set 6 CR +1 V +1 09/10/24, 20:05

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. core-ci voted on patch set 6 V -1 09/10/24, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65338

  9. Oli Bartsch uploaded patch set 7 V -1 09/11/24, 12:00

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. core-ci voted on patch set 7 V +1 09/11/24, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65432

  11. Benni Mack commented on patch set 7 CR -1 09/11/24, 12:17

    RecordFactory.php:169

    how can I find out if I'm in Frontend or in Backend context at this point? I think it would be quite helpful to know when I create such an Event Listener.
  12. Benni Mack uploaded patch set 8 CR -1 V +1 09/11/24, 12:33

  13. Benni Mack commented on patch set 8 CR +1 V +1 09/11/24, 12:33

    RecordFactory.php:169 Reply

    OK. If we assume field transformation, this is the best we can do for the time being
  14. core-ci voted on patch set 8 V -1 09/11/24, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65438

  15. core-ci voted on patch set 8 V +1 09/11/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65438

  16. Nikita Hovratov commented on patch set 8 09/11/24, 17:33

    Feature-104846-CustomFieldTransformationsForNewRecords.rst:19

    -are the properties [...] +are transformed [..]

    Feature-104846-CustomFieldTransformationsForNewRecords.rst:20

    what does "which might relations" mean? - with mighty relations or - which might relate to?

    Feature-104846-CustomFieldTransformationsForNewRecords.rst:60

    creates
  17. Nikita Hovratov voted on patch set 8 V +1 09/11/24, 18:01

  18. Oli Bartsch commented on patch set 9 CR +1 V +1 09/11/24, 19:06

    Published edit on patch set 8.
  19. Oli Bartsch commented on patch set 9 09/11/24, 19:07

    Feature-104846-CustomFieldTransformationsForNewRecords.rst:19 Reply

    Done

    Feature-104846-CustomFieldTransformationsForNewRecords.rst:20 Reply

    Done

    Feature-104846-CustomFieldTransformationsForNewRecords.rst:60 Reply

    Done
  20. Nikita Hovratov voted on patch set 9 CR +1 V +1 09/11/24, 19:09

  21. core-ci voted on patch set 9 V +1 09/11/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65480

  22. Benni Mack voted on patch set 9 CR +1 V +1 09/11/24, 19:42

  23. Oli Bartsch voted on patch set 9 CR +2 V +2 09/11/24, 19:46

  24. Oli Bartsch merged patch set 10 09/11/24, 19:46

  25. Lina Wolf commented on patch set 10 12/11/24, 08:01

    Please review the documentation for technical correctness: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/5139