85913[FEATURE] Enable custom field transformation
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Domain/Event/RecordCreationEvent.phpnew+106 −0
- typo3/sysext/core/Classes/Domain/RecordFactory.php2+11 −3
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104846-CustomFieldTransformationsForNewRecords.rst6new+90 −0
- typo3/sysext/core/Tests/Functional/Domain/RecordFactoryTest.php+74 −0
- typo3/sysext/core/Tests/Unit/Domain/RecordFactoryTest.php+19 −3
Review log 2233
Show 48 earlier messages
-
Oli Bartsch uploaded patch set 1 09/06/24, 10:47
-
core-ci voted on patch set 1 V -1 09/06/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64939
-
Oli Bartsch uploaded patch set 2
V -109/06/24, 13:42 -
core-ci voted on patch set 2 V +1 09/06/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64959
-
Oli Bartsch uploaded patch set 3
V +109/06/24, 14:42 -
Oli Bartsch uploaded patch set 4 09/06/24, 14:46
-
core-ci voted on patch set 3 V -1 09/06/24, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64978
-
core-ci voted on patch set 4 V -1 09/06/24, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64979
-
core-ci voted on patch set 4 V +1 09/06/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64979
-
Georg Ringer commented on patch set 5
V +109/06/24, 17:43Published edit on patch set 4. -
Georg Ringer voted on patch set 5 CR +1 V +1 09/06/24, 17:43
-
core-ci voted on patch set 5 V +1 09/06/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64995
-
Guido Schmechel voted on patch set 5 CR +1 V +1 09/07/24, 17:02
-
Benni Mack commented on patch set 5 CR -2 09/09/24, 07:38
I think we should rather work with RecordInterface... will work on that w/ Oli on that, -
Oli Bartsch uploaded patch set 6
CR +1V +109/10/24, 20:05Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 6 V -1 09/10/24, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65338
-
Oli Bartsch uploaded patch set 7
V -109/11/24, 12:00Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 7 V +1 09/11/24, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65432
-
Benni Mack commented on patch set 7 CR -1 09/11/24, 12:17
RecordFactory.php:169how can I find out if I'm in Frontend or in Backend context at this point? I think it would be quite helpful to know when I create such an Event Listener. -
Benni Mack uploaded patch set 8
CR -1V +109/11/24, 12:33 -
Benni Mack commented on patch set 8 CR +1 V +1 09/11/24, 12:33
RecordFactory.php:169ReplyOK. If we assume field transformation, this is the best we can do for the time being -
core-ci voted on patch set 8 V -1 09/11/24, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65438
-
core-ci voted on patch set 8 V +1 09/11/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65438
-
Nikita Hovratov commented on patch set 8 09/11/24, 17:33
Feature-104846-CustomFieldTransformationsForNewRecords.rst:19-are the properties [...] +are transformed [..]Feature-104846-CustomFieldTransformationsForNewRecords.rst:20what does "which might relations" mean? - with mighty relations or - which might relate to?Feature-104846-CustomFieldTransformationsForNewRecords.rst:60creates -
Nikita Hovratov voted on patch set 8 V +1 09/11/24, 18:01
-
Oli Bartsch commented on patch set 9
CR +1V +109/11/24, 19:06Published edit on patch set 8. -
Oli Bartsch commented on patch set 9 09/11/24, 19:07
Feature-104846-CustomFieldTransformationsForNewRecords.rst:19ReplyDoneFeature-104846-CustomFieldTransformationsForNewRecords.rst:20ReplyDoneFeature-104846-CustomFieldTransformationsForNewRecords.rst:60ReplyDone -
Nikita Hovratov voted on patch set 9 CR +1 V +1 09/11/24, 19:09
-
core-ci voted on patch set 9 V +1 09/11/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65480
-
Benni Mack voted on patch set 9 CR +1 V +1 09/11/24, 19:42
-
Oli Bartsch voted on patch set 9 CR +2 V +2 09/11/24, 19:46
-
Oli Bartsch merged patch set 10 09/11/24, 19:46
-
Lina Wolf commented on patch set 10 12/11/24, 08:01
Please review the documentation for technical correctness: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/5139