85914[TASK] Make treelist context aware
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oli Bartsch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/Sass/component/_treelist.scss+26 −9
- Build/Sources/Sass/typo3/_element_tree.scss+5 −12
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+2 −3
- typo3/sysext/backend/Resources/Public/Css/backend.css+5 −4
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.html4+2 −2
- typo3/sysext/info/Classes/Controller/PageInformationController.php+9 −5
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+15 −17
Review log 1419
-
Benjamin Kott uploaded patch set 1 09/06/24, 13:18
-
core-ci voted on patch set 1 V +1 09/06/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64958
-
Benjamin Kott uploaded patch set 2
V +109/06/24, 13:48 -
Benjamin Kott uploaded patch set 3 09/06/24, 13:50
-
core-ci voted on patch set 2 V +1 09/06/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64962
-
core-ci voted on patch set 3 V +1 09/06/24, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64963
-
Georg Ringer voted on patch set 3 CR +1 V +1 09/06/24, 17:44
-
Jasmina Ließmann commented on patch set 3 CR -1 V -1 09/06/24, 22:16
-
Benjamin Kott commented on patch set 3 09/07/24, 01:02
Statistic.html:131ReplyButton size is reduced here, because the treeicons need to fill the cell. The size has already been adopted in this patch, keeping the bigger size would need an even bigger increase. This will bloat up the table even more and make consume unnecessary space. Smaller slightly buttons here fixes the view with only a slight increase in normal listings. -
Benjamin Kott commented on patch set 3 CR -1 09/07/24, 01:05
needs to go in first. https://review.typo3.org/c/Packages/TYPO3.CMS/+/85725 -
Jasmina Ließmann commented on patch set 3 09/07/24, 10:07
Statistic.html:131ReplyThe current button size in "Detailed statistics" is the same as in "Pagetree Overview" of the "Info" module. I don't see any visible difference. If the button size for treeline tables is/should be changed, it should be the same in all occurrences (done in a standalone patch). Furthermore, both changes made in Statistic.html are outside the scope of this patch (context awareness) and shouldn't therefore be part of it. -
Benjamin Kott uploaded patch set 4
CR +1V +109/09/24, 08:09 -
Benjamin Kott commented on patch set 4 09/09/24, 08:11
Statistic.html:131ReplyMentioned views are now fixed, treeline icons were not visible at all ... Views are adjusted and mentioned in the commmit message. -
core-ci voted on patch set 4 V +1 09/09/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65063
-
Benjamin Franzke uploaded patch set 5
V +109/09/24, 11:40 -
Oli Bartsch voted on patch set 5 CR +1 V +1 09/09/24, 11:47
-
core-ci voted on patch set 5 V +1 09/09/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65086
-
Andreas Kienast voted on patch set 5 CR +2 V +2 09/09/24, 11:58
-
Andreas Kienast merged patch set 6 09/09/24, 11:58
Statistic.html:131