Review main Merged

85916[DOCS] Remove all highlight directives from dashboard docs

Lina Wolf CR +2 V +2 Hard +190 −177 updated 09/07/24, 14:13

Commit message

These directives are currently causing errors in opening rst
files in PHP storm.

Also it is best practice to only use explicit code blocks or
literalincludes.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1520

  1. Lina Wolf uploaded patch set 1 09/06/24, 15:13

  2. core-ci voted on patch set 1 V +1 09/06/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64981

  3. Chris Müller commented on patch set 1 09/06/24, 15:22

    AddingButtons.rst:79

    :file: is superfluous here.
  4. Chris Müller voted on patch set 1 CR -1 09/06/24, 15:22

  5. Lina Wolf commented on patch set 2 CR -1 V +1 09/06/24, 15:24

    Published edit on patch set 1.
  6. Lina Wolf commented on patch set 2 09/06/24, 15:25

    AddingButtons.rst:79 Reply

    Done
  7. core-ci voted on patch set 2 V +1 09/06/24, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64984

  8. Chris Müller voted on patch set 2 CR +1 V +1 09/06/24, 15:31

  9. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 09/06/24, 16:56

  10. Stefan Bürk voted on patch set 3 CR +1 V +1 09/06/24, 16:57

  11. core-ci voted on patch set 3 V +1 09/06/24, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64992

  12. Chris Müller voted on patch set 3 CR +1 V +1 09/06/24, 17:05

  13. Lina Wolf uploaded patch set 4 CR +1 V +1 09/07/24, 06:00

  14. core-ci voted on patch set 4 V +1 09/07/24, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65011

  15. Lina Wolf commented on patch set 4 09/07/24, 13:58

    Patchset 4 was meant to go on 12.4 it landed here accidently and needs to be deleted or reverted but I don't really know how to do that
  16. Stefan Bürk uploaded patch set 5 V +1 09/07/24, 14:05

  17. Stefan Bürk voted on patch set 5 CR +1 V +1 09/07/24, 14:06

  18. core-ci voted on patch set 5 V +1 09/07/24, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65018

  19. Garvin Hicking commented on patch set 5 CR +2 V +2 09/07/24, 14:13

    Thanks for ironing it out. Will take better care and learnt something 😅
  20. Garvin Hicking merged patch set 6 09/07/24, 14:13