Review main Merged

85921[TASK] Refactor AssetCollector tests

Simon Praetorius CR +2 V +2 Expert +846 −695 updated 09/09/24, 09:17

Commit message

In preparation for changes on `AssetRenderer`, most of the
unit tests are converted to functional tests. The test cases
are preserved, but duplicated to cover both the new
functional and the old unit tests.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Simon Praetorius uploaded patch set 1 09/07/24, 20:21

  2. core-ci voted on patch set 1 V +1 09/07/24, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65025

  3. Simon Schaufelberger voted on patch set 1 CR +1 09/07/24, 21:01

  4. Benni Mack voted on patch set 1 CR +1 V +1 09/09/24, 07:18

  5. Simon Praetorius voted on patch set 1 CR +2 V +2 09/09/24, 09:17

  6. Simon Praetorius merged patch set 2 09/09/24, 09:17