85922[BUGFIX] Fix new translation icon state in localization overview
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1723
-
Sébastien Delcroix uploaded patch set 1 09/07/24, 20:25
-
core-ci voted on patch set 1 V -1 09/07/24, 20:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65027
-
Sébastien Delcroix updated the commit message in patch set 2
V -109/07/24, 20:35 -
core-ci voted on patch set 2 V -1 09/07/24, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65028
-
Sébastien Delcroix uploaded patch set 3
V -109/07/24, 20:45 -
core-ci voted on patch set 3 V +1 09/07/24, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65029
-
Andreas Kienast commented on patch set 3 CR -1 09/11/24, 08:10
I do not like that this patch fiddles with internals of the icon API (`icon-state-*`). I'll try to come up with a better solution. -
Andreas Kienast commented on patch set 3 CR -2 09/11/24, 11:49
I had a talk with Benji – it's better to adjust the styling of `.disabled` / `[disabled]` as it's the parent than styling child elements on top. -
Sébastien Delcroix commented on patch set 3 09/12/24, 19:00
Reply
Sorry, as a newbie contributor I may lack knowledge about CSS in TYPO3, but I don't understand what do you mean :/ In this case, the .icon-markup only inherits opacity from parent .icon-state-disabled. The btn.disabled opacity doesn't transfer to its .icon-markup children. The only purely CSS way I see is something like "btn.disabled .icon-markup { opacity: inherit; }". I can let someone else more qualified on this patch ;) But, maybe we can have a totally different approach as suggested in issue comments : https://forge.typo3.org/issues/104077#note-5 By hiding the button by default and display it when the checkbox is checked, as it's already done at other places in the backend interface. By the way, this opacity issue affects also the clipboard buttons. For instance, in list mode with clipboard in single record mode, when you select a record.Reply
Allright, I'll learn something ;) I haven't found anything in documentation nor Slack on how to "synchronize" button and icon states. -
Benni Mack updated the commit message in patch set 4
V +110/18/24, 13:50Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benni Mack marked it work in progress 03/28/25, 14:06
-
Benni Mack commented on patch set 4 03/28/25, 14:06
Hey Sébastien. I will ping @akienast@scripting-base.de about this again. -
Andreas Kienast uploaded patch set 5 04/10/25, 07:14
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Kienast commented on patch set 5 CR 0 04/10/25, 07:15
This change is ready for review. -
core-ci voted on patch set 5 V -1 04/10/25, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77391
-
Andreas Kienast uploaded patch set 6
V -104/10/25, 13:18 -
core-ci voted on patch set 6 V -1 04/10/25, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77437
-
core-ci voted on patch set 6 V +1 04/10/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77437
-
Benni Mack voted on patch set 6 CR +1 V +1 04/10/25, 14:13
-
Stefan Bürk voted on patch set 6 CR +1 V +1 04/11/25, 08:17
-
Andreas Kienast voted on patch set 6 CR +2 V +2 04/11/25, 08:32
-
Andreas Kienast merged patch set 7 04/11/25, 08:39