85924[BUGFIX] Fix access to array values in SiteSettings->get()
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+2 −1
- typo3/sysext/core/Classes/Site/Entity/Site.php+2 −1
- typo3/sysext/core/Classes/Site/Entity/SiteSettings.php+35 −7
- typo3/sysext/core/Classes/Site/SiteSettingsFactory.php+36 −11
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/Set1/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/Set1/settings.definitions.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Site/Entity/SiteSettingsTest.phpnew+56 −0
- typo3/sysext/core/Tests/Functional/TypoScript/PageTsConfigFactoryTest.php+3 −1
Review log 1017
-
Benjamin Franzke uploaded patch set 1 09/09/24, 02:38
-
core-ci voted on patch set 1 V -1 09/09/24, 02:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65047
-
core-ci voted on patch set 1 V +1 09/09/24, 02:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65047
-
Benjamin Franzke uploaded patch set 2
V +109/09/24, 09:07 -
core-ci voted on patch set 2 V -1 09/09/24, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65067
-
Benjamin Franzke uploaded patch set 3
V -109/09/24, 09:25 -
core-ci voted on patch set 3 V +1 09/09/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65071
-
Benjamin Franzke uploaded patch set 4
V +109/09/24, 09:51 -
core-ci voted on patch set 4 V +1 09/09/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65075
-
Benjamin Franzke updated the commit message in patch set 5
V +109/09/24, 10:01 -
core-ci voted on patch set 5 V +1 09/09/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65078
-
Benjamin Franzke uploaded patch set 6
V +109/09/24, 10:22 -
core-ci voted on patch set 6 V +1 09/09/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65080
-
Stefan Bürk voted on patch set 6 CR +1 V +1 09/09/24, 10:59
-
Benni Mack voted on patch set 6 CR +1 V +1 09/09/24, 11:38
-
Benjamin Franzke voted on patch set 6 CR +2 V +2 09/09/24, 11:40
-
Benjamin Franzke merged patch set 7 09/09/24, 11:41