85925[TASK] Extend RecordInterface
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Benni Mack +1
Issues 1
Files 16
- typo3/sysext/backend/Classes/Preview/FluidBasedContentPreviewRenderer.php2+1 −0
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+15 −13
- typo3/sysext/core/Classes/DataHandling/RecordFieldTransformer.php+1 −1
- typo3/sysext/core/Classes/Domain/Exception/IncompleteRecordException.phpnew+25 −0
- typo3/sysext/core/Classes/Domain/Exception/RecordPropertyException.phpnew+26 −0
- typo3/sysext/core/Classes/Domain/Exception/RecordPropertyNotFoundException.phpnew+26 −0
- typo3/sysext/core/Classes/Domain/RawRecord.php+17 −22
- typo3/sysext/core/Classes/Domain/Record.php+27 −26
- typo3/sysext/core/Classes/Domain/RecordFactory.php+47 −29
- typo3/sysext/core/Classes/Domain/RecordInterface.php6+8 −1
- typo3/sysext/core/Documentation/Changelog/13.2/Feature-103783-RecordTransformationDataProcessor.rst+3 −3
- typo3/sysext/core/Tests/Functional/DataHandling/RecordFieldTransformerTest.php+200 −189
- typo3/sysext/core/Tests/Functional/Domain/RecordFactoryTest.php+48 −3
- typo3/sysext/core/Tests/Unit/Domain/RecordFactoryTest.php+4 −4
- typo3/sysext/frontend/Classes/DataProcessing/PageContentFetchingProcessor.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/RecordTransformationProcessor.php+1 −0
Review log 2637
Show 812 earlier messages
-
Oli Bartsch uploaded patch set 1 09/09/24, 10:23
-
core-ci voted on patch set 1 V -1 09/09/24, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65082
-
Oli Bartsch uploaded patch set 2
V -109/09/24, 13:12 -
Benjamin Franzke commented on patch set 2 CR -1 09/09/24, 13:18
-
core-ci voted on patch set 2 V -1 09/09/24, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65094
-
Oli Bartsch uploaded patch set 3
CR -1V -109/09/24, 13:31 -
core-ci voted on patch set 3 V +1 09/09/24, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65096
-
Benjamin Franzke commented on patch set 3 09/09/24, 13:38
RecordInterface.php:25Reply…move it into the implementation only until fluid is adapted. -
Benjamin Franzke voted on patch set 3 CR -1 09/09/24, 13:40
-
Oli Bartsch uploaded patch set 4
CR -1V +109/09/24, 16:22 -
core-ci voted on patch set 4 V +1 09/09/24, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65116
-
Stefan Bürk commented on patch set 4 09/09/24, 17:28
RecordInterface.php:25Reply@ben@bnf.dev don't get your statement here, maybe I miss some big picture here. `Psr\Container\ContainerInterface` is ment for dependency injection container and not for array-like access on objects which \ArrayAccess ensures: ``` $object = new RecordInterface(...); // new Record() / new RawRecord() $uid = $object['uid']; ``` Am I wrong here ? Beside that, don't get the connection to fluid here.
-
Oli Bartsch updated the commit message in patch set 5
V +109/09/24, 18:22 -
core-ci voted on patch set 5 V +1 09/09/24, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65131
-
Benjamin Franzke commented on patch set 5 09/10/24, 07:41
RecordInterface.php:25ReplyYes, i know it feels like an abuse of the ContainerInterface in the first place and I'm not sure how to explain my thoughts, but let me start this way: There are two patterns for ContainerInterface: * Dependency Injection * Service Location Dependency Injection is the process of automatically loading a dependency because you know it statically upfront. Service location is kind of lazy registration of certain/one service from a set of available service/object recipes. Service location is for example used in route or middleware dispatchers (services that inject ContainerInterface or symfony ServiceLocator (which itself implements ContainerInterface)). Now, our record objects, that are passed into the frontend templates are basically service location objects, as they allow to lazily load dependnecies (e.g. tt_content.image) from the record (=container). And the semantics are really quite identical, because a record is also meant to provide properties and relations as singletons (cache them, instead of recreation). So I came to the conclusion: The new automagic relation resolver is basically some kind of dependency injection (or better lazy dependency location), and therefore `ContainerInterface` became a logical and fitting choice. I understand that this feels like an abuse, but conceptionally I'm pretty sure we're basically applying the dependency injection pattern to content elements here. Now, -
Stefan Bürk commented on patch set 5 09/10/24, 17:42
RecordInterface.php:25ReplyThanks Benjamin to take the affort to explain the thoughts behind this. I know the ServiceLocator pattern (ZendFramework/Laminas etc ...) in general, and following your argumentation it make sense. -
Oli Bartsch commented on patch set 5 09/10/24, 19:18
RecordInterface.php:25ReplyDone -
Benni Mack voted on patch set 5 CR +1 09/10/24, 19:21
-
Oli Bartsch rebased onto patch set 6
CR +1V +109/10/24, 19:21 -
core-ci voted on patch set 6 V +1 09/10/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65322
-
Benni Mack voted on patch set 6 CR +1 V +1 09/10/24, 19:42
-
Oli Bartsch uploaded patch set 7
CR +1V +109/10/24, 20:31 -
Oli Bartsch uploaded patch set 8 09/10/24, 20:46
-
core-ci voted on patch set 7 V -1 09/10/24, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65348
-
core-ci voted on patch set 8 V -1 09/10/24, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65352
-
Benjamin Franzke commented on patch set 8 09/10/24, 21:12
`has()` and `get()`…in fluid, see https://github.com/TYPO3/Fluid/issues/1001FluidBasedContentPreviewRenderer.php:96what do you mean by `$output`, is that a concrete variable, or do you refer to some generic collected output? -
Oli Bartsch uploaded patch set 9
V -109/11/24, 09:46 -
Oli Bartsch commented on patch set 9 09/11/24, 09:48
Reply
DoneReply
DoneFluidBasedContentPreviewRenderer.php:96ReplyDone -
core-ci voted on patch set 9 V -1 09/11/24, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65407
-
Oli Bartsch rebased onto patch set 10
V -109/11/24, 10:05 -
core-ci voted on patch set 10 V +1 09/11/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65412
-
Benni Mack voted on patch set 10 CR +1 V +1 09/11/24, 11:42
-
Benjamin Franzke updated the commit message in patch set 11
CR +1V +109/11/24, 11:44 -
Benni Mack voted on patch set 11 CR +1 V +1 09/11/24, 11:44
-
Oli Bartsch voted on patch set 11 CR +2 V +2 09/11/24, 11:45
-
Oli Bartsch merged patch set 12 09/11/24, 11:45
-
core-ci voted on patch set 11 V +1 09/11/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65425
RecordInterface.php:25