85926[TASK] Avoid constructor argument of TemplatePaths
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Simon Praetorius +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1317
-
Simon Praetorius uploaded patch set 1 09/09/24, 13:28
-
core-ci voted on patch set 1 V +1 09/09/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65095
-
Simon Praetorius uploaded patch set 2
V +109/09/24, 14:53 -
core-ci voted on patch set 2 V -1 09/09/24, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65104
-
Benjamin Franzke commented on patch set 2 09/09/24, 15:19
I do not understand what `makeInstance` has to do with fluid v4. I mean, it's fine to remove it, but it shouldn't matter for fluid v4? What's the win for fluid here? Is the fluid v4 branch available somewhere? I'd like to understand the reasons. -
Simon Praetorius commented on patch set 2 09/09/24, 16:25
Reply
Sorry about the confusion. I wanted to achieve two to three things at once and recognized it on the way. This patch should be WIP. 😊 To clarify: makeInstance() would work just fine. However, all other parts in the core that create `TemplatePaths` don't use it, so I'd suggest to harmonize this. The main problem is that the constructor argument is used here, which is deprecated. -
Simon Praetorius marked it work in progress 09/09/24, 16:25
-
Simon Praetorius uploaded patch set 3
V -109/09/24, 16:48 -
Simon Praetorius marked it ready for review 09/09/24, 16:49
-
core-ci voted on patch set 3 V +1 09/09/24, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65119
-
Christian Kuhn uploaded patch set 4
V +109/09/24, 17:01 -
Christian Kuhn commented on patch set 4 CR +1 V +1 09/09/24, 17:01
Reply
Done -
core-ci voted on patch set 4 V +1 09/09/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65120
-
Stefan Bürk voted on patch set 4 CR +1 09/09/24, 17:15
-
Stefan Bürk voted on patch set 4 V +1 09/09/24, 17:15
-
Simon Praetorius voted on patch set 4 CR +2 V +2 09/09/24, 17:16
-
Simon Praetorius merged patch set 5 09/09/24, 17:16