Review main Merged

85931[TASK] Add integrity check for set and setting labels

Benjamin Franzke CR +2 V +2 Normal +142 −0 updated 09/10/24, 13:41

Commit message

Labels for site sets and site settings – as added in #104831 - are
now verified for completenes.

The script checkIntegritySetLabels.php checks for required
and optional labels to ensure labels.xlf and settings.definitions.yaml
are in sync.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 810

  1. Benjamin Franzke uploaded patch set 1 09/09/24, 19:01

  2. Benjamin Franzke uploaded patch set 2 09/09/24, 19:01

  3. core-ci voted on patch set 1 V -1 09/09/24, 19:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65133

  4. core-ci voted on patch set 2 V +1 09/09/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65134

  5. Benjamin Franzke commented on patch set 2 09/09/24, 19:30

    negative result enforced on purpose with patchset 1, see https://git.typo3.org/typo3/CI/cms/-/jobs/3719042
  6. Benni Mack voted on patch set 2 CR +1 V +1 09/10/24, 04:44

  7. Oli Bartsch voted on patch set 2 CR +1 V +1 09/10/24, 12:15

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 09/10/24, 12:58

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 09/10/24, 13:41

  10. Benjamin Franzke merged patch set 3 09/10/24, 13:41