Review main Merged

85932[TASK] Raise "phpstan/phpstan":"^1.12.3"

Stefan Bürk CR +2 V +2 Easy +10 −7 updated 09/09/24, 20:31

Commit message

PHPStan released a new version containing a bug
starting to report an error if a class extends
the native PHP `\SplObjectStorage` class [1]:

    Non-abstract class ... contains abstract method
    seek() from interface SeekableIterator.

Sadly, this is a not-ignorable error and cannot be
added to the baseline.

This change upgrades the version to the faulty version
and excludes the one file meanwhile. Not good, but the
only suitable solution for now.

Used command(s):

> Build/Scripts/runTests.sh -s composer -- \
  require --dev "phpstan/phpstan":"^1.12.3"

[1] https://github.com/phpstan/phpstan/issues/11665

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Stefan Bürk uploaded patch set 1 09/09/24, 19:10

  2. core-ci voted on patch set 1 V +1 09/09/24, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65136

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 09/09/24, 19:57

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 09/09/24, 20:00

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 09/09/24, 20:31

  6. Stefan Bürk merged patch set 2 09/09/24, 20:31