85935[FEATURE] Add color scheme switching
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Benjamin Franzke +1
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Benjamin Franzke +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 20
- Build/Sources/Sass/component/_root.scss+24 −0
- Build/Sources/TypeScript/backend/color-scheme-manager.ts2new+39 −0
- Build/Sources/TypeScript/backend/color-scheme-switch.ts4new+92 −0
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php2+35 −0
- typo3/sysext/backend/Classes/Backend/ColorScheme.php4new+52 −0
- typo3/sysext/backend/Classes/Controller/BackendController.php+3 −0
- typo3/sysext/backend/Classes/Controller/ColorSchemeController.php8new+50 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+5 −0
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+12 −0
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/UserToolbarItemDropDown.html4+7 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/color-scheme-manager.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/color-scheme-switch.jsnew+38 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php2+8 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104868-AddColorSchemeSwitching.rst new+25 −0
- typo3/sysext/install/Classes/Controller/AbstractController.php+1 −0
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+1 −1
- typo3/sysext/install/Resources/Private/Templates/Layout/Init.html+1 −1
- typo3/sysext/setup/Configuration/user.tsconfignew+1 −0
- typo3/sysext/setup/ext_tables.php2+7 −1
Review log 64102
Show 4677 earlier messages
-
Andreas Nedbal uploaded patch set 1 09/09/24, 19:18
-
core-ci voted on patch set 1 V -1 09/09/24, 19:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65140
-
Benjamin Franzke commented on patch set 1 09/09/24, 19:34
ModuleTemplate.php:91Why on body, can we set this on `<html>`? That means it is applied as soon as CSS is loaded, even before `<body>` is loaded. -
Andreas Nedbal uploaded patch set 2
V -109/09/24, 19:35 -
core-ci voted on patch set 2 V -1 09/09/24, 19:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65142
-
Andreas Nedbal uploaded patch set 3
V -109/09/24, 19:41 -
Andreas Nedbal uploaded patch set 4 09/09/24, 19:46
-
Andreas Nedbal commented on patch set 4 09/09/24, 19:50
ColorSchemeController.php:48ReplyDone -
core-ci voted on patch set 3 V -1 09/09/24, 19:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65143
-
core-ci voted on patch set 4 V +1 09/09/24, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65146
-
Andreas Nedbal uploaded patch set 5
V +109/09/24, 20:22 -
core-ci voted on patch set 5 V +1 09/09/24, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65150
-
Andreas Nedbal uploaded patch set 6
V +109/09/24, 20:44 -
core-ci voted on patch set 6 V +1 09/09/24, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65154
-
Andreas Nedbal uploaded patch set 7
V +109/09/24, 20:55 -
core-ci voted on patch set 7 V +1 09/09/24, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65155
-
Andreas Kienast commented on patch set 7 09/10/24, 06:24
ColorScheme.php:36Why do we need dedicated methods that return a WeakMap? Can't we simply use `match()`? -
Andreas Nedbal uploaded patch set 8
V +109/10/24, 07:24 -
Andreas Nedbal commented on patch set 8 09/10/24, 07:26
ColorScheme.php:36ReplyDone -
Benni Mack commented on patch set 8 09/10/24, 07:28
I recommend doing this in the Enum -
Benni Mack commented on patch set 8 09/10/24, 07:30
I personally do not see the use case for the global feature toggle. If this is a User TS Config option, we can ensure that only some editors have this feature as option, or even "enforce" to have a certain setting, or remove the setting completely... -
core-ci voted on patch set 8 V +1 09/10/24, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65182
-
Benni Mack commented on patch set 8 09/10/24, 07:31
ColorSchemeController.php:35Can't we have the Enum handle such things? you know... tryFrom...ColorSchemeController.php:48Can't we have the Enum handle such things?UserToolbarItemDropDown.html:63please move to XLFext_tables.php:112Can't we have the Enum handle such things? getAvailableItemsForSelection() -
Andreas Nedbal uploaded patch set 9
V +109/10/24, 07:52 -
core-ci voted on patch set 9 V -1 09/10/24, 08:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65189
-
Andreas Nedbal uploaded patch set 10
V -109/10/24, 08:18 -
Andreas Nedbal uploaded patch set 11 09/10/24, 08:27
-
core-ci voted on patch set 10 V -1 09/10/24, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65191
-
Andreas Nedbal commented on patch set 11 09/10/24, 08:31
ColorSchemeController.php:35ReplyDoneColorSchemeController.php:48ReplyDoneUserToolbarItemDropDown.html:63ReplyDoneext_tables.php:112ReplyDone -
core-ci voted on patch set 11 V -1 09/10/24, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65192
-
Andreas Nedbal uploaded patch set 12
V -109/10/24, 09:10 -
core-ci voted on patch set 12 V -1 09/10/24, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65195
-
Andreas Nedbal uploaded patch set 13
V -109/10/24, 09:34 -
core-ci voted on patch set 13 V +1 09/10/24, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65200
-
Andreas Nedbal commented on patch set 13 09/10/24, 10:23
ModuleTemplate.php:91ReplyDone -
Andreas Kienast commented on patch set 13 09/10/24, 10:39
ColorSchemeController.php:33Should we bail out early if this is no POST request at all?PageRenderer.php:288=== -
Benjamin Franzke commented on patch set 13 CR -2 09/10/24, 10:40
UserToolbarItemDropDown.html:67I want a 3-way switch here, not three button entries… https://www.conrad.de/de/p/tru-components-tc-9354012-wippschalter-250-v-ac-3-a-4-x-ein-ein-rastend-1-st-2338503.html?hk=SEM&WT.mc_id=google_pla&gad_source=1&gclid=CjwKCAjw3P-2BhAEEiwA3yPhwFEsrZTAgUK9SlI3g6UEPSo8Fky5PxeM67qZYwCgb_sp-qF5z9hyvRoCfmsQAvD_BwE -
Benni Mack commented on patch set 13 CR -1 09/10/24, 11:07
Instead of a global (new) feature switch, one could easily use this on a per-user, per-group or instance-wide setting: # disable the field (thus, also the weird three-way-dropdown) setup.fields.colorScheme.disabled = 1 # enforce light mode setup.override.colorScheme = light # set a default value setup.default.colorScheme = auto See https://docs.typo3.org/m/typo3/reference-tsconfig/12.4/en-us/UserTsconfig/Setup.html#setup -
Benjamin Franzke commented on patch set 13 CR 0 09/10/24, 11:28
UserToolbarItemDropDown.html:67Replynvm -
Andreas Nedbal uploaded patch set 14
CR -1V +109/10/24, 11:37 -
Andreas Nedbal uploaded patch set 15 09/10/24, 11:42
-
core-ci voted on patch set 14 V +1 09/10/24, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65220
-
Andreas Nedbal commented on patch set 15 09/10/24, 11:44
ColorSchemeController.php:33ReplyDonePageRenderer.php:288ReplyDone -
core-ci voted on patch set 15 V +1 09/10/24, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65221
-
Andreas Nedbal uploaded patch set 16
V +109/10/24, 13:54 -
core-ci voted on patch set 16 V +1 09/10/24, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65256
-
Andreas Nedbal uploaded patch set 17
V +109/10/24, 14:14 -
Andreas Nedbal uploaded patch set 18 09/10/24, 14:16
-
core-ci voted on patch set 17 V +1 09/10/24, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65258
-
core-ci voted on patch set 18 V +1 09/10/24, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65259
-
Andreas Nedbal uploaded patch set 19
V +109/10/24, 15:02 -
core-ci voted on patch set 19 V -1 09/10/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65268
-
Andreas Nedbal uploaded patch set 20
V -109/10/24, 15:24 -
core-ci voted on patch set 20 V +1 09/10/24, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65273
-
Andreas Nedbal rebased onto patch set 21
V +109/10/24, 15:35 -
core-ci voted on patch set 21 V +1 09/10/24, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65275
-
Andreas Nedbal updated the commit message in patch set 22
V +109/10/24, 15:53 -
core-ci voted on patch set 22 V +1 09/10/24, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65277
-
Andreas Nedbal updated the commit message in patch set 23
V +109/10/24, 16:20 -
core-ci voted on patch set 23 V -1 09/10/24, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65282
-
Andreas Nedbal uploaded patch set 24
V -109/10/24, 16:35 -
core-ci voted on patch set 24 V +1 09/10/24, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65286
-
Andreas Nedbal uploaded patch set 25
V +109/10/24, 17:25 -
Andreas Nedbal uploaded patch set 26 09/10/24, 17:32
-
core-ci voted on patch set 25 V -1 09/10/24, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65299
-
core-ci voted on patch set 26 V -1 09/10/24, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65301
-
Andreas Nedbal uploaded patch set 27
V -109/10/24, 18:24 -
Andreas Nedbal uploaded patch set 28 09/10/24, 18:25
-
core-ci voted on patch set 27 V -1 09/10/24, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65317
-
core-ci voted on patch set 28 V +1 09/10/24, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65318
-
Benni Mack commented on patch set 28 09/10/24, 19:15
ColorScheme.php:30EXT:backend is referencing EXT:setup LLLs is probably not a good idea. -
Andreas Nedbal uploaded patch set 29
V +109/10/24, 19:23 -
Andreas Nedbal commented on patch set 29 09/10/24, 19:23
ColorScheme.php:30ReplyDone -
core-ci voted on patch set 29 V -1 09/10/24, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65323
-
core-ci commented on patch set 29 09/10/24, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65323
-
Andreas Nedbal rebased onto patch set 30
V -109/10/24, 19:34 -
core-ci voted on patch set 30 V -1 09/10/24, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65326
-
Andreas Nedbal uploaded patch set 31
V -109/10/24, 19:51 -
core-ci voted on patch set 31 V +1 09/10/24, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65331
-
Andreas Nedbal uploaded patch set 32
V +109/10/24, 21:24 -
Benni Mack commented on patch set 32 CR -1 09/10/24, 21:27
UserToolbarItem.php:177does not work... LocalizationUtility is Extbase, and static. calling in a non-static way. I recommend using $GLOBALS['LANG'] a.k.a. LanguageService. -
core-ci voted on patch set 32 V +1 09/10/24, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65357
-
Andreas Nedbal uploaded patch set 33
CR -1V +109/11/24, 06:45 -
core-ci voted on patch set 33 V +1 09/11/24, 06:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65378
-
Andreas Nedbal commented on patch set 33 09/11/24, 06:54
UserToolbarItem.php:177ReplyDone -
Andreas Nedbal uploaded patch set 34
V +109/11/24, 07:05 -
core-ci voted on patch set 34 V +1 09/11/24, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65379
-
Benjamin Kott voted on patch set 34 CR +1 V +1 09/11/24, 13:11
-
Andreas Nedbal uploaded patch set 35
CR +1V +109/11/24, 13:37 -
core-ci voted on patch set 35 V +1 09/11/24, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65455
-
Benjamin Franzke commented on patch set 35 09/11/24, 13:51
color-scheme-manager.ts:24https://forge.typo3.org/issues/93270 we should probably merge https://review.typo3.org/c/Packages/TYPO3.CMS/+/67432 before -
Andreas Nedbal uploaded patch set 36
V +109/11/24, 13:55 -
Benjamin Franzke commented on patch set 35 09/11/24, 13:55
color-scheme-switch.ts:49no space herecolor-scheme-switch.ts:55no space here -
core-ci voted on patch set 36 V +1 09/11/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65457
-
Benjamin Franzke uploaded patch set 37
V +109/11/24, 14:05 -
Benjamin Franzke commented on patch set 37 09/11/24, 14:05
color-scheme-manager.ts:24Replylater.color-scheme-switch.ts:49ReplyDonecolor-scheme-switch.ts:55ReplyDone -
Benjamin Franzke voted on patch set 37 CR +1 V +1 09/11/24, 14:06
-
Benni Mack voted on patch set 37 CR +1 09/11/24, 14:08
-
Benjamin Kott voted on patch set 37 CR +1 V +1 09/11/24, 14:08
-
core-ci voted on patch set 37 V +1 09/11/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65460
-
Andreas Nedbal voted on patch set 37 CR +2 V +2 09/11/24, 14:15
-
Andreas Nedbal merged patch set 38 09/11/24, 14:15
ColorSchemeController.php:48