Review main Merged

85936[TASK] Make tabs context aware

Benjamin Kott CR +2 V +2 Hard +600 −338 updated 09/10/24, 09:04

Commit message

We are dropping the Bootstrap CSS definitions for
all navs to have more control about the styling of
the nav elements. From now on we are shipping
custom css adapted to our needs. The new nav
element styling is context aware and adapts to
light and dark color schemes.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 34

Show 14 more files

Review log 1522

  1. Benjamin Kott uploaded patch set 1 09/09/24, 19:27

  2. core-ci voted on patch set 1 V -1 09/09/24, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65141

  3. Benjamin Kott uploaded patch set 2 V -1 09/09/24, 19:43

  4. Benjamin Kott uploaded patch set 3 09/09/24, 19:44

  5. Benjamin Kott uploaded patch set 4 09/09/24, 19:54

  6. core-ci voted on patch set 2 V -1 09/09/24, 19:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65144

  7. core-ci voted on patch set 3 V -1 09/09/24, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65145

  8. core-ci voted on patch set 4 V -1 09/09/24, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65147

  9. Benjamin Kott uploaded patch set 5 V -1 09/09/24, 20:08

  10. core-ci voted on patch set 5 V +1 09/09/24, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65149

  11. Benjamin Franzke commented on patch set 5 V -1 09/09/24, 20:44

    _nav.scss:108

    An active tab should force background color and not show a different hover color.
  12. Benjamin Kott uploaded patch set 6 V +1 09/09/24, 21:04

  13. Benjamin Kott commented on patch set 6 09/09/24, 21:05

    _nav.scss:108 Reply

    Done
  14. core-ci voted on patch set 6 V +1 09/09/24, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65156

  15. Andreas Kienast commented on patch set 6 V -1 09/10/24, 06:02

    If the screen is too narrow, tabs break into multiple lines. This is fine, unless one tab is marked with a validation error, the icon is then vertically misaligned.
    tab
  16. Benjamin Kott uploaded patch set 7 V +1 09/10/24, 06:58

  17. Benjamin Kott commented on patch set 6 09/10/24, 06:59

    Reply

    Done
  18. core-ci voted on patch set 7 V +1 09/10/24, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65181

  19. Andreas Kienast voted on patch set 7 CR +1 V +1 09/10/24, 07:28

  20. Oli Bartsch voted on patch set 7 CR +1 V +1 09/10/24, 08:29

  21. Benjamin Kott voted on patch set 7 CR +2 V +2 09/10/24, 09:04

  22. Benjamin Kott merged patch set 8 09/10/24, 09:04