85936[TASK] Make tabs context aware
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Oli Bartsch +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 34
- Build/Sources/Sass/component/forms/_form-validation.scss+27 −27
- Build/Sources/Sass/component/_elementbrowser.scss+1 −1
- Build/Sources/Sass/component/_nav.scss2+185 −3
- Build/Sources/Sass/component/_tabs.scssdeleted+0 −15
- Build/Sources/Sass/typo3/_element_tab.scssdeleted+0 −71
- Build/Sources/Sass/typo3/_element_tceforms.scss+4 −1
- Build/Sources/Sass/typo3/_main_form.scss+1 −1
- Build/Sources/Sass/variables/_main.scss+12 −30
- Build/Sources/Sass/backend.scss+0 −1
- Build/Sources/Sass/workspace.scss+0 −34
- Build/Sources/Sass/_legacy.scss+0 −12
- Build/Sources/Sass/_minimal.scss+1 −2
- Build/Sources/TypeScript/backend/form-engine-validation.ts+1 −1
- Build/Sources/TypeScript/backend/tabs.ts+5 −2
- Build/Sources/TypeScript/workspaces/renderable/record-information.ts+9 −6
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+3 −3
- typo3/sysext/backend/Resources/Private/Partials/ModuleTemplate/Tabs.html+10 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+55 −77
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tabs.js+1 −1
Show 14 more files
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/RecordDownloadWithPresetCest.php+1 −1
- typo3/sysext/impexp/Resources/Private/Templates/Export.html+36 −8
- typo3/sysext/impexp/Resources/Private/Templates/Import.html+36 −8
- typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html+10 −1
- typo3/sysext/setup/Resources/Private/Templates/Main.html+9 −2
- typo3/sysext/styleguide/Classes/Controller/ComponentsController.php+13 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+21 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Navs.htmlnew+129 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Tab.html+10 −5
- typo3/sysext/workspaces/Resources/Public/Css/preview.css+0 −6
- typo3/sysext/workspaces/Resources/Public/JavaScript/renderable/record-information.js+10 −7
Review log 1522
-
Benjamin Kott uploaded patch set 1 09/09/24, 19:27
-
core-ci voted on patch set 1 V -1 09/09/24, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65141
-
Benjamin Kott uploaded patch set 2
V -109/09/24, 19:43 -
Benjamin Kott uploaded patch set 3 09/09/24, 19:44
-
Benjamin Kott uploaded patch set 4 09/09/24, 19:54
-
core-ci voted on patch set 2 V -1 09/09/24, 19:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65144
-
core-ci voted on patch set 3 V -1 09/09/24, 19:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65145
-
core-ci voted on patch set 4 V -1 09/09/24, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65147
-
Benjamin Kott uploaded patch set 5
V -109/09/24, 20:08 -
core-ci voted on patch set 5 V +1 09/09/24, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65149
-
Benjamin Franzke commented on patch set 5 V -1 09/09/24, 20:44
-
Benjamin Kott uploaded patch set 6
V +109/09/24, 21:04 -
Benjamin Kott commented on patch set 6 09/09/24, 21:05
_nav.scss:108ReplyDone -
core-ci voted on patch set 6 V +1 09/09/24, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65156
-
Andreas Kienast commented on patch set 6 V -1 09/10/24, 06:02
If the screen is too narrow, tabs break into multiple lines. This is fine, unless one tab is marked with a validation error, the icon is then vertically misaligned.tab -
Benjamin Kott uploaded patch set 7
V +109/10/24, 06:58 -
Benjamin Kott commented on patch set 6 09/10/24, 06:59
Reply
Done -
core-ci voted on patch set 7 V +1 09/10/24, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65181
-
Andreas Kienast voted on patch set 7 CR +1 V +1 09/10/24, 07:28
-
Oli Bartsch voted on patch set 7 CR +1 V +1 09/10/24, 08:29
-
Benjamin Kott voted on patch set 7 CR +2 V +2 09/10/24, 09:04
-
Benjamin Kott merged patch set 8 09/10/24, 09:04
_nav.scss:108