Review main Merged

85938[TASK] Drop @internal for sudo-mode AccessLifetime

Oliver Hader CR +2 V +2 Easy +0 −2 updated 09/10/24, 04:37

Commit message

Since AccessLifetime is allowed to be use in any module/route
configuration, it should not be marked `@internal`.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Lina Wolf +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Lina Wolf +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 09/09/24, 20:28

  2. core-ci voted on patch set 1 V +1 09/09/24, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65151

  3. Lina Wolf voted on patch set 1 CR +1 V +1 09/09/24, 20:54

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 09/10/24, 02:45

  5. Georg Ringer voted on patch set 1 CR +2 V +2 09/10/24, 04:37

  6. Georg Ringer merged patch set 2 09/10/24, 04:37