Review 12.4 Merged

85953[BUGFIX] Remove invalid has-changed class on new records

Benjamin Kott CR +2 V +2 Easy +15 −8 updated 09/10/24, 12:17

Commit message

We are removing the misused has-changed class for new
records and replacing it with a dedicated is-new class.
This class is used only to check if a record needs to be
persisted before certain actions, such as closing or
previewing a record, can be executed.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 3

Files 3

Review log 57

  1. Benjamin Kott commented on patch set 1 09/10/24, 11:50

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine.ts * typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js
  2. core-ci voted on patch set 1 V -1 09/10/24, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65223

  3. Benjamin Kott uploaded patch set 2 V -1 09/10/24, 12:08

  4. Benjamin Kott marked it ready for review 09/10/24, 12:08

  5. core-ci voted on patch set 2 V +1 09/10/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65228

  6. Benjamin Kott voted on patch set 2 CR +2 V +2 09/10/24, 12:17

  7. Benjamin Kott merged patch set 3 09/10/24, 12:17