Review main Abandoned

85955[TASK] Revert "[FEATURE] Introduce LatestChangedPages dashboard widget"

Oli Bartsch CR 0 V 0 Hard +0 −401 updated 09/17/24, 07:05

Commit message

This reverts commit 945a8385c732aca9fc9a70c1f6622725a4549752.

Reason for revert: This patch got in too quickly and has a couple of technical issues and implementation details:

* It's not visible if the page itself was changed or a content on that page
* We missed the opportunity to have a generic implementation which supports the history of any kind of record
* Widget options are not documented
* Wrong property for change date display
* Missing language information
* View webpage does not show localized page
* Edit content button for localized pages does not work but triggers the page module to show a localized page as default page (also the page is not selected in the tree)
* Another couple of code quality issues have been detected, e.g. missing strict type checks and wrong case in function calls

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 810

  1. Oli Bartsch uploaded patch set 1 09/11/24, 07:07

  2. core-ci voted on patch set 1 V +1 09/11/24, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65380

  3. Simon Schaufelberger commented on patch set 1 09/11/24, 07:22

    too
  4. Simon Schaufelberger updated the commit message in patch set 2 V +1 09/11/24, 08:53

  5. Simon Schaufelberger commented on patch set 2 09/11/24, 08:53

    Reply

    Done
  6. Ulrich Mathes voted on patch set 2 CR +1 V +1 09/11/24, 08:57

  7. core-ci voted on patch set 2 V +1 09/11/24, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65391

  8. Georg Ringer voted on patch set 2 CR +1 V +1 09/11/24, 15:25

  9. Benni Mack commented on patch set 2 CR -1 09/11/24, 15:47

  10. Oli Bartsch abandoned the change 09/17/24, 07:05