Review main Merged

85972[TASK] Adjust code comment about deprecation of Controller attribute

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 09/10/24, 08:21

Commit message

The `AsController` has been added to v12 next to the
`Controller` attribute. Later has been deprecated in
v13 and will be removed in v14.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 09/10/24, 07:41

  2. Benjamin Franzke commented on patch set 1 09/10/24, 07:43

    Just a TASK, and commit message is too long.
  3. core-ci voted on patch set 1 V +1 09/10/24, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65184

  4. Oli Bartsch updated the commit message in patch set 2 V +1 09/10/24, 07:52

  5. Oli Bartsch commented on patch set 2 09/10/24, 07:52

    Reply

    Done
  6. Jochen Roth voted on patch set 2 CR +1 V +1 09/10/24, 07:55

  7. core-ci voted on patch set 2 V +1 09/10/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65190

  8. Benjamin Kott voted on patch set 2 CR +1 V +1 09/10/24, 08:05

  9. Oli Bartsch voted on patch set 2 CR +2 V +2 09/10/24, 08:21

  10. Oli Bartsch merged patch set 3 09/10/24, 08:21