Review main Merged

85984[TASK] Introduce backend module layouts

Benjamin Kott CR +2 V +2 Nightmare +1899 −1866 updated 06/17/26, 21:47

Commit message

Add a ModuleLayout enum (wide/normal) that controls the
maximum content width of backend modules. The default layout
is "wide" (full width), while "normal" constrains the module
body to a maximum width of 1320px and centers it horizontally.

Controllers for content-focused modules are switched to
ModuleLayout::NORMAL for improved readability on wide screens.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 36

Show 16 more files

Review log 2029

Show 34 earlier messages
  1. Benjamin Kott uploaded patch set 1 09/10/24, 16:19

  2. core-ci voted on patch set 1 V +1 09/10/24, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65281

  3. Benjamin Kott uploaded patch set 2 V +1 09/10/24, 16:46

  4. Benjamin Franzke voted on patch set 2 CR +1 V +1 09/10/24, 16:47

  1. core-ci voted on patch set 2 V +1 09/10/24, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65290

  2. Benjamin Kott voted on patch set 2 CR -2 09/10/24, 17:57

  3. Benjamin Kott rebased onto patch set 3 CR +1 V +1 09/10/24, 18:09

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  4. Benjamin Kott commented on patch set 3 CR -2 09/10/24, 18:10

    NOT NOW
  5. core-ci voted on patch set 3 V +1 09/10/24, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65310

  6. Benjamin Franzke marked it work in progress 11/04/24, 15:24

  7. Benjamin Kott uploaded patch set 4 V +1 03/23/26, 09:41

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. Benjamin Kott commented on patch set 4 CR 0 03/23/26, 09:42

    This change is ready for review.
  9. core-ci voted on patch set 4 V -1 03/23/26, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98441

  10. Garvin Hicking commented on patch set 4 03/23/26, 09:55

    ```suggestion width of the view for the docheader and the module body. ```
  11. Benjamin Kott updated the commit message in patch set 5 V -1 03/23/26, 10:03

  12. core-ci voted on patch set 5 V -1 03/23/26, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98447

  13. Benjamin Kott uploaded patch set 6 V -1 03/23/26, 10:52

  14. core-ci voted on patch set 6 V -1 03/23/26, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98454

  15. Benjamin Kott uploaded patch set 7 V -1 03/23/26, 11:52

  16. core-ci voted on patch set 7 V -1 03/23/26, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98465

  17. Benjamin Kott rebased onto patch set 8 V -1 03/23/26, 12:29

  18. core-ci voted on patch set 8 V -1 03/23/26, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98476

  19. core-ci voted on patch set 8 V +1 03/23/26, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98476

  20. Benjamin Kott commented on patch set 8 03/23/26, 13:53

    Reply

    Done
  21. Benjamin Franzke voted on patch set 8 CR +1 V +1 03/23/26, 14:02

  22. Andreas Nedbal voted on patch set 8 CR +1 V +1 03/24/26, 10:21

  23. Benjamin Kott voted on patch set 8 CR +2 V +2 03/24/26, 10:25

  24. Benjamin Kott merged patch set 9 03/24/26, 10:25

  25. Simon Schaufelberger commented on patch set 9 06/17/26, 21:47

    ModuleLayout.php:21 Unresolved

    Why is this internal? How else will I change the layout of my own backend module if not using these enums?

    ModuleTemplate.php:183 Unresolved

    Why is this internal? How else will I change the layout of my own backend module if not using this method?