85986[TASK] Introduce new `DefaultButton` to render `button`-tags as replacement for `LinkButton`
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 34
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+4 −8
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −2
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −2
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownItem.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownRadio.php+2 −2
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownToggle.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/DefaultButton.phpnew+115 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/LanguageSelectorBuilder.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php+2 −1
- typo3/sysext/backend/Classes/Template/Components/ComponentFactory.php+16 −6
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/LanguageSelectorBuilderTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/LinkButtonTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Template/Components/MenuTest.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107823-ComponentFactoryForBackendComponents.rst+3 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.php+1 −1
Show 14 more files
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/ContentElementsCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FormFrameworkCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FrontendLoginCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/IndexedSearchCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/SitemapXmlCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/NewRecordTypeCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/SchedulerTaskWizardCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+2 −2
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −2
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+1 −2
- typo3/sysext/info/Classes/Controller/PageInformationController.php+1 −2
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+1 −2
Review log 1828
Show 23 earlier messages
-
Ayke Halder uploaded patch set 1 09/10/24, 16:51
-
Ayke Halder uploaded patch set 2 09/10/24, 16:54
-
core-ci voted on patch set 1 V -1 09/10/24, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65291
-
core-ci voted on patch set 2 V -1 09/10/24, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65292
-
Ayke Halder uploaded patch set 3
V -109/10/24, 17:06 -
core-ci voted on patch set 3 V -1 09/10/24, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65294
-
Ayke Halder uploaded patch set 4
V -109/10/24, 17:15 -
core-ci voted on patch set 4 V -1 09/10/24, 17:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65295
-
Ayke Halder uploaded patch set 5
V -109/10/24, 17:25 -
core-ci voted on patch set 5 V -1 09/10/24, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65300
-
Ayke Halder uploaded patch set 6
V -109/10/24, 21:21 -
core-ci voted on patch set 6 V +1 09/10/24, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65356
-
Garvin Hicking commented on patch set 6 01/30/26, 15:11
Do you think we can abandon this one due to the ButtonComponent refactorings? -
Ayke Halder commented on patch set 6 01/30/26, 16:43
Reply
There is still code creating buttons by using `$this->componentFactory->createLinkButton()` with `->setHref('#')` - this must be fixed. ``` $ find . -iname '*.php' -print0 | xargs -0 grep ">setHref('#')" ./sysext/backend/Classes/Controller/PageLayoutController.php: ->setHref('#') ./sysext/backend/Classes/Controller/RecordListController.php: ->setHref('#') ./sysext/backend/Classes/Controller/EditDocumentController.php: ->setHref('#') ./sysext/backend/Classes/Controller/EditDocumentController.php: ->setHref('#') ./sysext/backend/Classes/Controller/EditDocumentController.php: ->setHref('#') ./sysext/backend/Classes/Controller/EditDocumentController.php: ->setHref('#') ./sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownItem.php: * ->setHref('#') ./sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownRadio.php: * ->setHref('#') ./sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownRadio.php: * ->setHref('#') ./sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownToggle.php: * ->setHref('#') ./sysext/backend/Classes/Template/Components/Buttons/LanguageSelectorBuilder.php: ->setHref('#') ./sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php: * ->setHref('#') ./sysext/backend/Classes/Template/Components/Buttons/LinkButton.php: * ->setHref('#') ./sysext/backend/Classes/Template/Components/ComponentFactory.php: ->setHref('#') ./sysext/backend/Tests/Unit/Template/Components/Button/LinkButtonTest.php: $button->setHref('#')->setTitle('huhu'); ./sysext/backend/Tests/Unit/Template/Components/MenuTest.php: $item = $menu2->makeMenuItem()->setHref('#')->setTitle('Husel'); ./sysext/form/Classes/Controller/FormManagerController.php: ->setHref('#') ./sysext/info/Classes/Controller/InfoModuleController.php: ->setHref('#') ./sysext/info/Classes/Controller/PageInformationController.php: ->setHref('#') ./sysext/workspaces/Classes/Controller/ReviewController.php: ->setHref('#') . ``` -
Ayke Halder uploaded patch set 7
V +101/30/26, 17:33 -
core-ci voted on patch set 7 V -1 01/30/26, 17:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94693
-
Ayke Halder uploaded patch set 8
V -101/30/26, 18:14 -
core-ci voted on patch set 8 V -1 01/30/26, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94697
-
Ayke Halder uploaded patch set 9
V -101/30/26, 19:33 -
core-ci voted on patch set 9 V +1 01/30/26, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94700
-
Ayke Halder uploaded patch set 10
V +101/30/26, 20:10 -
core-ci voted on patch set 10 V +1 01/30/26, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94704
-
Benni Mack commented on patch set 10 11/14/26, 16:38
I'm abandoning this change. Since it was written, GenericButton has been reworked (#107823 and follow-ups). It now renders a <button> by default, takes arbitrary attributes such as type="button", supports icon, label and disabled state, and is available via ComponentFactory::createGenericButton(). That covers everything DefaultButton would add, so a second class would only add more button API. The underlying problem is still valid ofc: there are still LinkButtons with href="#" in EditDocumentController, createViewButton(), LanguageSelectorBuilder, FormManagerController, the info module controllers and ReviewController, but that's a different approach than this one. -
Benni Mack abandoned the change 11/14/26, 16:38
see comment -
Ayke Halder commented on patch set 10 11/14/26, 16:47
Reply Unresolved
GenericButton would inheritate from this new DefaultButton. So GenericButton is actually a more specific implementation than DefaultButton here. Or the other way around: GenericButton is to specific to solve all issues - that's why `createLinkButton()` with `->setHref('#')` is still in use, as there are cases that can not be covered by the not so generic GenericButton. As you mentioned: > The underlying problem is still valid ofc: there are still LinkButtons with href="#" -
Ayke Halder commented on patch set 10 11/14/26, 16:53
Reply
Update on this: ``` $ find . -iname '*.php' -print0 | xargs -0 grep ">setHref('#')" ./Build/tests/packages/playwright_helper/Classes/EventListener/AddDisabledDocHeaderButtonListener.php: ->setHref('#') ./typo3/sysext/backend/Classes/Controller/EditDocumentController.php: ->setHref('#') ./typo3/sysext/backend/Classes/Controller/EditDocumentController.php: ->setHref('#') ./typo3/sysext/backend/Classes/Controller/EditDocumentController.php: ->setHref('#') ./typo3/sysext/backend/Classes/Controller/EditDocumentController.php: ->setHref('#') ./typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownItem.php: * ->setHref('#') ./typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownRadio.php: * ->setHref('#') ./typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownRadio.php: * ->setHref('#') ./typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownToggle.php: * ->setHref('#') ./typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php: * ->setHref('#') ./typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php: * ->setHref('#') ./typo3/sysext/backend/Classes/Template/Components/Buttons/LanguageSelectorBuilder.php: ->setHref('#') ./typo3/sysext/backend/Classes/Template/Components/ComponentFactory.php: ->setHref('#') ./typo3/sysext/backend/Tests/Functional/Template/Components/DocHeaderComponentTest.php: ->setHref('#') ./typo3/sysext/backend/Tests/Functional/Template/Components/DocHeaderComponentTest.php: ->setHref('#') ./typo3/sysext/backend/Tests/Functional/Template/Components/DocHeaderComponentTest.php: ->setHref('#') ./typo3/sysext/backend/Tests/Functional/Template/Components/DocHeaderComponentTest.php: ->setHref('#') ./typo3/sysext/backend/Tests/Functional/Template/Components/DocHeaderComponentTest.php: ->setHref('#') ./typo3/sysext/backend/Tests/Functional/Template/Components/DocHeaderComponentTest.php: ->setHref('#') ./typo3/sysext/backend/Tests/Functional/Template/Components/DocHeaderComponentTest.php: ->setHref('#') ./typo3/sysext/backend/Tests/Functional/Template/Components/DocHeaderComponentTest.php: ->setHref('#') ./typo3/sysext/backend/Tests/Unit/Template/Components/Button/LinkButtonTest.php: $button->setHref('#')->setTitle('huhu'); ./typo3/sysext/backend/Tests/Unit/Template/Components/Button/DropDownItemTest.php: $item = new DropDownItem()->setLabel('Info')->setHref('#'); ./typo3/sysext/backend/Tests/Unit/Template/Components/MenuTest.php: $item = new MenuItem()->setHref('#')->setTitle('Husel'); ./typo3/sysext/backend/Tests/Unit/Template/Components/MenuTest.php: $item = new MenuItem()->setHref('#')->setTitle('Item1'); ./typo3/sysext/backend/Tests/Unit/Template/Components/MenuTest.php: $item = new MenuItem()->setHref('#')->setTitle('Item2'); ./typo3/sysext/form/Classes/Controller/FormManagerController.php: ->setHref('#') ./typo3/sysext/info/Classes/Controller/PageInformationController.php: ->setHref('#') ./typo3/sysext/info/Classes/Controller/TranslationStatusController.php: ->setHref('#') ./typo3/sysext/workspaces/Classes/Controller/ReviewController.php: ->setHref('#') ``` -
Benni Mack commented on patch set 10 11/15/26, 07:51
Reply
want to revive the change then? -
Ayke Halder commented on patch set 10 11/16/26, 11:17
Reply Unresolved
As soon as I have time for this. And I'll first contact @bo@cedev.de to get to know the intended direction of button implementation for TYPO3.