85987[FEATURE] Introduce LatestChangedPages dashboard widget
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Frank Nägler +1
-
Verified V +2 Done
- Georg Ringer +2
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-104878-IntroduceDashboardWidgetForPagesWithLatestChanges.rstnew+24 −0
- typo3/sysext/dashboard/Classes/Widgets/LatestChangedPagesWidget.php12new+197 −0
- typo3/sysext/dashboard/Configuration/Backend/DashboardWidgetGroups.php+3 −0
- typo3/sysext/dashboard/Configuration/Services.yaml4+15 −0
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf+46 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/LatestChangedPagesWidget.html9new+116 −0
Review log 2326
Show 1 earlier messages
-
Ulrich Mathes uploaded patch set 1 09/10/24, 17:04
-
core-ci voted on patch set 1 V +1 09/10/24, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65293
-
Chris Müller commented on patch set 1 CR -1 09/10/24, 17:13
Thanks for your feature :-) Please also add a changelog file, you can find more information here: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/AddingDocumentation/Index.html#changelog As a blueprint for your feature have a look at: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.2/Feature-99552-IntroduceMissingMetaDescriptionWidget.html -
Frank Nägler commented on patch set 1 CR -1 09/10/24, 18:13
on it, will push an update -
Frank Nägler uploaded patch set 2
CR -1V +109/10/24, 19:02 -
Frank Nägler commented on patch set 2 CR +1 V +1 09/10/24, 19:04
looks good, I added the missing rst file and fixed some minor issues in template and code. Great patch, thank you! -
core-ci voted on patch set 2 V +1 09/10/24, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65321
-
Stefan Bürk commented on patch set 2 CR -1 09/10/24, 19:18
LatestChangedPagesWidget.php:54No QueryBuilder reuse. Don't create it and store it in a property. Create new each time you need to execute something. -
Stefan Bürk commented on patch set 2 09/10/24, 19:21
LatestChangedPagesWidget.php:54Replyhttps://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Database/QueryBuilder/Index.html#instantiation > Never instantiate and initialize the query builder manually using dependency injection or GeneralUtility::makeInstance(), otherwise you will miss essential dependencies and runtime setup. > The QueryBuilder holds internal state and must not be reused for different queries. In addition, a reuse comes with a significant performance penalty and memory consumption. Use one query builder per query. Get a fresh one by calling $connection->createQueryBuilder() if the same table is involved, or use $connectionPool->getQueryBuilderForTable() for a query to a different table. Do not worry, creating those object instances is quite fast. -
Frank Nägler commented on patch set 2 CR -1 09/10/24, 19:41
LatestChangedPagesWidget.php:54ReplyAck, will take care -
Frank Nägler uploaded patch set 3
CR -1V +109/10/24, 19:44 -
Frank Nägler commented on patch set 2 CR -1 V +1 09/10/24, 19:45
LatestChangedPagesWidget.php:54ReplyDone -
Frank Nägler voted on patch set 3 CR +1 V +1 09/10/24, 19:45
-
core-ci voted on patch set 3 V +1 09/10/24, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65327
-
Georg Ringer voted on patch set 3 CR +2 V +2 09/10/24, 19:50
-
Georg Ringer merged patch set 4 09/10/24, 19:50
-
Oli Bartsch commented on patch set 4 09/10/24, 21:23
LatestChangedPagesWidget.php:104Should be a strict checkLatestChangedPagesWidget.php:110Let's check strict "$pageRecord === false || $pageRecord === []"LatestChangedPagesWidget.php:130Should be getRootLineLatestChangedPagesWidget.php:160could be static and even shorthandedLatestChangedPagesWidget.html:24page.pageRecord.tstamp represents the time the page was edited. in case a content element has been changed, which leads to the widget showing this page, the date is wrong as it shows when the page properties itself were last changed.LatestChangedPagesWidget.html:52There should be an icon for the pages language -
Oli Bartsch commented on patch set 4 09/10/24, 21:25
Services.yaml:205For the default limit of 10 items, this height is not sufficient and cut's off the items. I actually did not get that I can scroll on the first sight. -
Oli Bartsch commented on patch set 4 09/10/24, 21:28
LatestChangedPagesWidget.html:75This does not select the page in the page tree. It's furthermore not working for localized pages since they are treated as default => showing translation options etc. -
Oli Bartsch commented on patch set 4 09/10/24, 21:28
Unresolved
Post -1 -
Simon Schaufelberger commented on patch set 4 09/10/24, 22:27
LatestChangedPagesWidget.html:24Replyit should be using the `SYS_LASTCHANGED` column -
Oli Bartsch commented on patch set 4 09/11/24, 06:58
Services.yaml:204We might want to add a dedicated icon -
Oli Bartsch wrote 09/11/24, 07:07
Created a revert of this change as I436b630e88920e6d6dbe8061b38d1905d7511229 -
Frank Nägler commented on patch set 4 09/11/24, 08:34
Working on a patch to fix your pointsLatestChangedPagesWidget.php:104ReplyAcknowledgedLatestChangedPagesWidget.php:110ReplyAcknowledgedLatestChangedPagesWidget.php:130ReplyAcknowledgedLatestChangedPagesWidget.php:160ReplyAcknowledgedServices.yaml:204Reply Unresolvedcan be done later if we have an iconServices.yaml:205Reply Unresolvedthe container/table is scrollableLatestChangedPagesWidget.html:24ReplyAcknowledgedLatestChangedPagesWidget.html:75ReplyHow can this be fixed? -
Ulrich Mathes commented on patch set 4 09/11/24, 09:05
LatestChangedPagesWidget.html:75ReplyBy providing `language: page.pageRecord.sys_language_uid` parameter, the correct translation is shown. If we can't find a way to select the page in page tree, maybe we have to get rid of this link. -
Frank Nägler commented on patch set 4 09/11/24, 20:35
LatestChangedPagesWidget.html:52ReplyAcknowledgedLatestChangedPagesWidget.html:75ReplyAcknowledged