Review main Abandoned

85996[WIP][TASK] Tests for EXT:rte_ckeditor/Configuration/RTE/Processing.yaml

Oliver Hader CR 0 V 0 Normal +78 −0 updated 10/04/24, 15:54

Commit message

+ removeTags is not evaluated with array items

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 68

  1. Oliver Hader uploaded patch set 1 09/10/24, 20:31

  2. core-ci voted on patch set 1 V +1 09/10/24, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65347

  3. Garvin Hicking commented on patch set 1 09/12/24, 11:19

    RteHtmlParserTest.php:52

    Note, this needs to be "processing" here. The HTMLParser class evaluates "proper" array structures, not the ['proc.']['HTMLParser_db.']['removeTags.'] structure. For this test it doesn't really matter, because removeTags from YAML isn't interpreted. (Page TSConfig would be, though!)
  4. Garvin Hicking commented on patch set 1 09/12/24, 11:36

    RteHtmlParserTest.php:52 Reply

    Hm, no, it goes deeper than that. Investigating, seems there are discrepancies between 'processing' and 'proc.'.
  5. Garvin Hicking updated the commit message in patch set 2 V +1 09/12/24, 12:46

  6. Garvin Hicking commented on patch set 2 09/12/24, 12:47

    RteHtmlParserTest.php:52 Reply

    Never mind. 'proc.' was right of course due to internal mappings still, I was mislead by a comment that said to use 'processing'. But that lead to too many issues. Will push a patch with a follow-up to this to address the actual bug.
  7. core-ci voted on patch set 2 V +1 09/12/24, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65560

  8. Oliver Hader abandoned the change 10/04/24, 15:54