Review main Merged

85998[BUGFIX] Fix detection of local settings in settings overview

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 09/11/24, 09:09

Commit message

Site local settings (defined in the sites settings.yaml file)
need to be taken into account in the site overview, only
if they are based on definitions. Therefore the setting
map (which is based on definitions) has to be evaluated
instead of the flat settings map (which contains all
settings, defined and legacy anonymous settings).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 09/10/24, 21:07

  2. core-ci voted on patch set 1 V +1 09/10/24, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65354

  3. Benjamin Kott voted on patch set 1 CR +1 V +1 09/11/24, 08:31

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 09/11/24, 09:00

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/11/24, 09:09

  6. Benjamin Franzke merged patch set 2 09/11/24, 09:09