85999[FEATURE] Introduce TcaSchemaListCommand
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1624
-
Nikita Hovratov uploaded patch set 1 09/10/24, 21:39
-
core-ci voted on patch set 1 V +1 09/10/24, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65358
-
Nikita Hovratov uploaded patch set 2
V +109/10/24, 21:45 -
core-ci voted on patch set 2 V -1 09/10/24, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65359
-
Nikita Hovratov uploaded patch set 3
V -109/11/24, 07:44 -
core-ci voted on patch set 3 V +1 09/11/24, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65382
-
Oli Bartsch commented on patch set 3 09/11/24, 08:55
SchemaListCommand.php:78We should check the counts before calling array_combine() -
Nikita Hovratov uploaded patch set 4
V +109/11/24, 09:23 -
Nikita Hovratov commented on patch set 4 09/11/24, 09:24
SchemaListCommand.php:77Reply UnresolvedNo, but it's rather unusual that record types are added via itemsProcFunc. Normally it is added with EMU:addTcaSelectItem. I'm not sure, if we should handle such exceptional case.SchemaListCommand.php:78ReplyDone -
Nikita Hovratov uploaded patch set 5 09/11/24, 09:32
-
core-ci voted on patch set 4 V +1 09/11/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65398
-
core-ci voted on patch set 5 V +1 09/11/24, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65401
-
Nikita Hovratov uploaded patch set 6
V +109/11/24, 17:22 -
core-ci voted on patch set 6 V +1 09/11/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65473
-
Simon Schaufelberger commented on patch set 6 09/11/24, 20:14
SchemaListCommand.php:28I would call this class TcaSchemaListCommand to make it clear what kind of Schema -
Nikita Hovratov uploaded patch set 7
V +109/11/24, 20:22 -
Nikita Hovratov uploaded patch set 8 09/11/24, 20:22
-
Nikita Hovratov commented on patch set 8 09/11/24, 20:23
SchemaListCommand.php:28ReplyDone -
core-ci voted on patch set 7 V +1 09/11/24, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65490
-
core-ci voted on patch set 8 V +1 09/11/24, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65491
-
Simon Schaufelberger voted on patch set 8 CR +1 09/11/24, 20:40
-
Stefan Bürk commented on patch set 8 09/11/24, 23:42
The output format (single table) is kind of weired. Can we make this kind of uncluttered a bit ``` * iterate TCA tables -> display table name / info as section * interate TCA table columns -> display field name / options / marks (first line) -> select items chop down (next row, empty cols for row aka repeat) ``` or at least prepare it in that way (to add more tca info later. And having at least a `--table` option (recurring) would be nice so it can be limited ? Maybe I miss something .. however , reducing from 4 cols to 2 cols by having table name / labe as section label would help I guess. -
Nikita Hovratov commented on patch set 8 09/12/24, 06:48
Reply Unresolved
Showing the fields can be done with other, similar commands like: tca:schema:show --table I wanted a compact list, which can be easily exported for debugging purposes. Grouping it in sections defies this approach. But yes, we could add a --table command to limit it at least. -
Nikita Hovratov abandoned the change 12/05/24, 19:30
not working on it anymore
SchemaListCommand.php:77