Review main Abandoned

86005[BUGFIX] End CSS declarations in icons.ts with semicolon

Andreas Kienast CR 0 V 0 Easy +24 −24 updated 10/09/24, 09:52

Commit message

The CSS in icons.ts was pasted from an optimized CSS build, which causes
issues now and may will in the future as semicolons from the respective
last CSS declaration were removed.

Due to a following declaration, the property `--icon-opacity-disabled`
is now broken.

All CSS declarations are now explicitly ended with a semicolon as we
don't aim to mimic build optimizer output in a manual fashion.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 09/11/24, 08:53

  2. core-ci voted on patch set 1 V +1 09/11/24, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65392

  3. Benjamin Franzke commented on patch set 1 CR -1 09/11/24, 09:14

    icons.ts:33 Unresolved

    Won't work, inline rendering is broken since https://review.typo3.org/c/Packages/TYPO3.CMS/+/77786 as it removed the `vertial-align` hack. Sth. like this is needed: ``` line-height: var(--icon-size, 1em); vertical-align: -22% ``` I've described that in the commit message of > 75419: [BUGFIX] Make <typo3-backend-icon> CSS backwards compatible | https://review.typo3.org/c/Packages/TYPO3.CMS/+/75419 Can easily be verified by rendering the icon inline e.g. via: ``` <h1><typo3-backend-icon identifier="actions-close" size="default"></typo3-backend-icon>New TYPO3 site</h1> ``` ...the icon is not properly aligned, but bound to the top.
  4. Benjamin Franzke abandoned the change 10/09/24, 09:52