Review main Merged

86006[TASK] Add functional tests for SysNoteRepository

Garvin Hicking CR +2 V +2 Normal +109 −0 updated 09/15/24, 08:49

Commit message

This patch adds functional tests to verify the SysNoteRepository
fetches proper/valid data to be displayed in widgets for example,
and respects personal/foreign/deleted attributes in sys_note
records.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 913

  1. Garvin Hicking uploaded patch set 1 09/11/24, 09:06

  2. core-ci voted on patch set 1 V -1 09/11/24, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65394

  3. core-ci commented on patch set 1 09/11/24, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65394

  4. Garvin Hicking uploaded patch set 2 V -1 09/11/24, 09:20

    Use proper sort order
  5. core-ci voted on patch set 2 V +1 09/11/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65396

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 09/14/24, 09:58

  7. Stefan Bürk commented on patch set 2 CR -1 09/14/24, 23:49

    SysNoteRepositoryTest.php:61

    `assertSame()` and not `assertEqual()` strict <-> not-strict comparision

    SysNoteRepositoryTest.php:91

    `assertSame()` and not `assertEqual()` strict <-> not-strict comparision
  8. Stefan Bürk uploaded patch set 3 CR +1 V +1 09/14/24, 23:52

  9. Stefan Bürk commented on patch set 3 09/14/24, 23:52

    SysNoteRepositoryTest.php:61 Reply

    Done

    SysNoteRepositoryTest.php:91 Reply

    Done
  10. core-ci voted on patch set 3 V +1 09/14/24, 23:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65774

  11. Stefan Bürk voted on patch set 3 CR +1 V +1 09/15/24, 03:21

  12. Anja Leichsenring voted on patch set 3 CR +2 V +2 09/15/24, 08:49

  13. Anja Leichsenring merged patch set 4 09/15/24, 08:49