86007[FEATURE] Introduce config.sendCacheHeadersForSharedCaches
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1318
-
Benni Mack uploaded patch set 1 09/11/24, 09:12
-
core-ci voted on patch set 1 V +1 09/11/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65395
-
Benni Mack uploaded patch set 2
V +109/11/24, 17:40 -
Benni Mack uploaded patch set 3 09/11/24, 17:43
-
core-ci voted on patch set 2 V -1 09/11/24, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65474
-
core-ci voted on patch set 3 V +1 09/11/24, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65477
-
Oliver Hader commented on patch set 3 09/12/24, 10:12
Is there a "simple" way to test the new behavior with a "common CDN configuration"? -
Benni Mack commented on patch set 3 09/12/24, 10:15
Reply
If you are familiar with TYPO3 config settings `reverseProxyIP` and make sure it applies like this (thus, REMOTE_ADDR matches a different result when set to reverseProxyIP) then you should receive different HTTP Response Headers. -
Benjamin Franzke uploaded patch set 4
V +109/14/24, 07:49Resolve Merge Conflict -
core-ci voted on patch set 4 V +1 09/14/24, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65744
-
Benjamin Franzke commented on patch set 4 CR -1 09/14/24, 08:04
TypoScriptFrontendController.php:812While it's good to check this in a reverse-proxy setup, there may be shared caches that do not use a reverse-proxy setup: nginx cache be configured to store php results in a cache (fastcgi cache). In this case the webserver itself is the shared cache and there is not trusted reverse proxy ip configured/available. I'd love some additional option to force these headers. I'm thinking about: ``` # only send if behind reverse proxy config.sendCacheHeadersForSharedCaches = auto # always send config.sendCacheHeadersForSharedCaches = 1 ```TypoScriptFrontendController.php:818I'd love to send `private, no-store` to the client, but I'm not sure how (commercial) caching proxies react to that. I guess there will be some, that'd ignore the cache alltogether in that case. At least `must-revalidate` would be nice, but then again, the proxy could think it's has to revalidate (although they should only use `proxy-revalidate`). -
Benjamin Franzke uploaded patch set 5
CR -1V +109/14/24, 08:21 -
Benjamin Franzke commented on patch set 5 09/14/24, 08:21
TypoScriptFrontendController.php:812ReplyDoneTypoScriptFrontendController.php:818Replypost poned. -
core-ci voted on patch set 5 V +1 09/14/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65745
-
Stefan Bürk voted on patch set 5 CR +1 09/14/24, 22:40
-
Stefan Bürk voted on patch set 5 V +1 09/14/24, 23:39
-
Benni Mack commented on patch set 5 CR +2 V +2 09/15/24, 06:12
thank you both -
Benni Mack merged patch set 6 09/15/24, 06:12